Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 12428009: Remove WebIOSurfaceLayer (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove WebIOSurfaceLayer Thanks to Antoine's work in crrev.com/173545 and WebKit r137653, plugins manage their compositing layers using the cc:: types instead of WebKit types. This means WebIOSurfaceLayer isn't used anywhere and can be deleted. R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187050

Patch Set 1 #

Patch Set 2 : fix gyp file #

Patch Set 3 : remove include from web_compositor_support_impl.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M webkit/compositor_bindings/compositor_bindings.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_compositor_support_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_compositor_support_impl.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
D webkit/compositor_bindings/web_io_surface_layer_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D webkit/compositor_bindings/web_io_surface_layer_impl.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Cleaning up some dead code. Will remove the type from WebKit after this lands (so ...
7 years, 9 months ago (2013-03-08 00:47:46 UTC) #1
piman
lgtm
7 years, 9 months ago (2013-03-08 01:33:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12428009/7001
7 years, 9 months ago (2013-03-08 18:53:43 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 18:59:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12428009/7001
7 years, 9 months ago (2013-03-08 19:28:31 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-08 22:27:07 UTC) #6
Message was sent while issue was closed.
Change committed as 187050

Powered by Google App Engine
This is Rietveld 408576698