Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/isolate_driver.py

Issue 1242783002: Modify isolate_driver.py to always generate a wrapping .isolate. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@1_read_only
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate_driver.py
diff --git a/tools/isolate_driver.py b/tools/isolate_driver.py
index 6c9f11886633c1343297e885204e50cbb3560fa2..c5d80fc01a1a04aaa26e300ddaa5dbf1abc620db 100755
--- a/tools/isolate_driver.py
+++ b/tools/isolate_driver.py
@@ -280,20 +280,16 @@ def main():
mode = args[0] if args else None
isolate = None
isolated = None
- is_component = False
for i, arg in enumerate(args):
if arg == '--isolate':
isolate = i + 1
if arg == '--isolated':
isolated = i + 1
- if arg == 'component=shared_library':
- is_component = True
if isolate is None or isolated is None or not mode:
print >> sys.stderr, 'Internal failure'
return 1
- if is_component:
- create_wrapper(args, isolate, isolated)
+ create_wrapper(args, isolate, isolated)
# In 'prepare' mode just collect all required information for postponed
# isolated.py invocation later, store it in *.isolated.gen.json file.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698