[Android] Supporting floating select ActionModes for web content

chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
index 8b0fe2d895a960dc23b3e97578c5350a6c6991d7..ac7a588691f6a624a558994e1c1ad3b696c28037 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java
@@ -15,7 +15,6 @@ import android.os.Handler;
 import android.os.Message;
 import android.text.TextUtils;
 import android.util.Pair;
-import android.view.ActionMode;
 import android.view.ContextMenu;
 import android.view.KeyEvent;
 import android.view.View;
@@ -71,7 +70,7 @@ import org.chromium.content.browser.ActivityContentVideoViewClient;
 import org.chromium.content.browser.ContentVideoViewClient;
 import org.chromium.content.browser.ContentViewClient;
 import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.WebActionMode;
+import org.chromium.content.browser.WebActionModeCallback;
 import org.chromium.content.browser.WebActionModeCallback.ActionHandler;
 import org.chromium.content.browser.crypto.CipherFactory;
 import org.chromium.content_public.browser.GestureStateListener;
@@ -760,18 +759,9 @@ public class ChromeTab extends Tab {
             }
 
             @Override
-            public WebActionMode startActionMode(
-                    View view, ActionHandler actionHandler, boolean floating) {
-                if (floating) return null;
-                ChromeWebActionModeCallback callback =
-                        new ChromeWebActionModeCallback(view.getContext(), actionHandler);
-                ActionMode actionMode = view.startActionMode(callback);
-                return actionMode != null ? new WebActionMode(actionMode) : null;
-            }
-
-            @Override
-            public boolean supportsFloatingActionMode() {
-                return false;
+            public WebActionModeCallback getWebActionModeCallback(
+                    Context context, ActionHandler actionHandler) {
+                return new ChromeWebActionModeCallback(context, actionHandler);

[aurimas (slooooooooow), 2015/08/20 22:20:16]

Why do we even need ChromeWebActionModeCallback? Can we simply use
WebActionModeCallback and move onCreateActionMode() to WebActionModeCallback as
it is only using ui/ layer?

[jdduke (slow), 2015/08/20 23:13:14]

I believe the only reason we have it is to supply a custom title to the
ActionMode for tablets (see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...).

We could instead have a method |getActionModeTitle()|? Or is there a better way
to embed the asset? Alternatively, I wonder what the harm is in moving the
string resource into content/ and just fetching the title directly? I don't
suppose you know why this is the way it is currently?

[aurimas (slooooooooow), 2015/08/21 01:30:23]

I think moves the string to content is fine and just have WebActionModeCallback
there.

             }
 
             @Override