[Android] Supporting floating select ActionModes for web content

chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tab;
 
 import android.annotation.TargetApi;
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.Intent;
 import android.graphics.Rect;
 import android.media.AudioManager;
 import android.os.Build;
 import android.os.Handler;
 import android.os.Message;
 import android.text.TextUtils;
 import android.util.Pair;
-import android.view.ActionMode;
 import android.view.ContextMenu;
 import android.view.KeyEvent;
 import android.view.View;
 
 import org.chromium.base.Log;
 import org.chromium.base.TraceEvent;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeActivity;
@@ skipping 35 matching lines @@
 import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
 import org.chromium.chrome.browser.tabmodel.TabModelUtils;
 import org.chromium.chrome.browser.util.FeatureUtilities;
 import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;
 import org.chromium.components.navigation_interception.InterceptNavigationDelegate;
 import org.chromium.components.navigation_interception.NavigationParams;
 import org.chromium.content.browser.ActivityContentVideoViewClient;
 import org.chromium.content.browser.ContentVideoViewClient;
 import org.chromium.content.browser.ContentViewClient;
 import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.WebActionMode;
+import org.chromium.content.browser.WebActionModeCallback;
 import org.chromium.content.browser.WebActionModeCallback.ActionHandler;
 import org.chromium.content.browser.crypto.CipherFactory;
 import org.chromium.content_public.browser.GestureStateListener;
 import org.chromium.content_public.browser.InvalidateTypes;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.content_public.browser.NavigationController;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_public.browser.WebContentsObserver;
 import org.chromium.content_public.common.ConsoleMessageLevel;
 import org.chromium.content_public.common.Referrer;
@@ skipping 668 matching lines @@
                 mActivity.getTabModelSelector().openNewTab(loadUrlParams,
                         TabLaunchType.FROM_LONGPRESS_FOREGROUND, ChromeTab.this, isIncognito());
             }
 
             @Override
             public boolean doesPerformWebSearch() {
                 return true;
             }
 
             @Override
-            public WebActionMode startActionMode(
-                    View view, ActionHandler actionHandler, boolean floating) {
-                if (floating) return null;
-                ChromeWebActionModeCallback callback =
-                        new ChromeWebActionModeCallback(view.getContext(), actionHandler);
-                ActionMode actionMode = view.startActionMode(callback);
-                return actionMode != null ? new WebActionMode(actionMode) : null;
+            public WebActionModeCallback getWebActionModeCallback(
+                    Context context, ActionHandler actionHandler) {
+                return new ChromeWebActionModeCallback(context, actionHandler);

[aurimas (slooooooooow), 2015/08/20 22:20:16]

Why do we even need ChromeWebActionModeCallback? Can we simply use
WebActionModeCallback and move onCreateActionMode() to WebActionModeCallback as
it is only using ui/ layer?

[jdduke (slow), 2015/08/20 23:13:14]

I believe the only reason we have it is to supply a custom title to the
ActionMode for tablets (see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...).

We could instead have a method |getActionModeTitle()|? Or is there a better way
to embed the asset? Alternatively, I wonder what the harm is in moving the
string resource into content/ and just fetching the title directly? I don't
suppose you know why this is the way it is currently?

[aurimas (slooooooooow), 2015/08/21 01:30:23]

I think moves the string to content is fine and just have WebActionModeCallback
there.

             }
 
             @Override
-            public boolean supportsFloatingActionMode() {
-                return false;
-            }
-
-            @Override
             public ContentVideoViewClient getContentVideoViewClient() {
                 return new ActivityContentVideoViewClient(mActivity) {
                     @Override
                     public void enterFullscreenVideo(View view) {
                         super.enterFullscreenVideo(view);
                         FullscreenManager fullscreenManager = getFullscreenManager();
                         if (fullscreenManager != null) {
                             fullscreenManager.setOverlayVideoMode(true);
                             // Disable double tap for video.
                             if (getContentViewCore() != null) {
@@ skipping 572 matching lines @@
                 didFinishPageLoad();
             }
         }
     };
 
     @VisibleForTesting
     public OverrideUrlLoadingResult getLastOverrideUrlLoadingResultForTests() {
         return mLastOverrideUrlLoadingResult;
     }
 }