Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1242573003: llvm_coverage_build: Use CC and CXX variables by default (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

llvm_coverage_build: Use CC and CXX variables by default NOTRY=true BUG=skia:2430 Committed: https://skia.googlesource.com/skia/+/5150a77ee70b4ea07e3c1721f74b0f3c79a4bd58

Patch Set 1 #

Patch Set 2 : Tweak version comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/llvm_coverage_build View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
borenet
We'll override these variables on the bot.
5 years, 5 months ago (2015-07-17 13:56:04 UTC) #2
mtklein
lgtm
5 years, 5 months ago (2015-07-17 14:14:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242573003/1
5 years, 5 months ago (2015-07-17 14:14:26 UTC) #5
borenet
Patch set 2 explains why we need 3.6.
5 years, 5 months ago (2015-07-17 14:20:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242573003/20001
5 years, 5 months ago (2015-07-17 14:20:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242573003/20001
5 years, 5 months ago (2015-07-17 14:30:37 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 14:31:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5150a77ee70b4ea07e3c1721f74b0f3c79a4bd58

Powered by Google App Engine
This is Rietveld 408576698