Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/llvm_coverage_build

Issue 1242573003: llvm_coverage_build: Use CC and CXX variables by default (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Tweak version comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/llvm_coverage_build
diff --git a/tools/llvm_coverage_build b/tools/llvm_coverage_build
index 07b547f06bd226979afbf0988151ecb566e137b5..85e9db964167ae7ae95ffaf8bdee37208d459f45 100755
--- a/tools/llvm_coverage_build
+++ b/tools/llvm_coverage_build
@@ -7,12 +7,13 @@
#
# $ tools/llvm_coverage_build [any other flags to pass to make...]
#
-# This script assumes the use of Clang >=3.6.
+# This script assumes the use of Clang 3.6. Earlier versions do not support
+# the flags we use in the build, and 3.7+ hit asserts during compilation.
#
set -e
-export CC="$(which clang)"
-export CXX="$(which clang++)"
+export CC="${CC:-$(which clang)}"
+export CXX="${CXX:-$(which clang++)}"
if [[ -z "${CC}" ]] || [[ -z "${CXX}" ]]; then
echo "Couldn't find Clang on this machine!"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698