bluetooth: Implement MissingCharacteristicAdapter and GetBaseGATTService.

bluetooth: Implement MissingCharacteristicAdapter and GetBaseGATTService.

Part of the refactoring of the test platform. MissingCharacteristicAdapter
is used for test what happens when a characteristic gets removed.

Design doc:

https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit?usp=sharing

Blink-side patch: http://crrev.com/1242813003

BUG=499552
Committed: https://crrev.com/338cf0096006ea5bdefbbe2c0e4042698fde3b9c
Cr-Commit-Position: refs/heads/master@{#339912}

[ortuno, 2015-07-20 22:16:50]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-07-20 22:16:51]

@jyasskin: PTAL

[Jeffrey Yasskin, 2015-07-20 22:21:28]

lgtm

https://codereview.chromium.org/1242403002/diff/40001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/1242403002/diff/40001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:226:
//       Returns: uuid + “ Identifier”
We'll probably need a way to allow multiple services on a device with the same
UUID but different identifiers.

[ortuno, 2015-07-20 22:30:50]

On 2015/07/20 at 22:21:28, jyasskin wrote:
> lgtm
> 
>
https://codereview.chromium.org/1242403002/diff/40001/content/shell/browser/l...
> File
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):
> 
>
https://codereview.chromium.org/1242403002/diff/40001/content/shell/browser/l...
>
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:226:
//       Returns: uuid + “ Identifier”
> We'll probably need a way to allow multiple services on a device with the same
UUID but different identifiers.

Yeah. Generating device addresses is pretty annoying as well. I was thinking
about using global variables: device_num, service_num, etc. to generate
addresses and identifiers and increment them every time we make a new object.
Need to think some more about it.

[ortuno, 2015-07-21 20:23:37]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-07-21 20:23:38]

@scheib: PTAL

[scheib, 2015-07-21 20:46:23]

LGTM, perhaps with:

https://codereview.chromium.org/1242403002/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1242403002/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:237:

// Intentionally NOT adding a characteristic to generic_access service.

[ortuno, 2015-07-21 21:03:08]

Thanks!

https://codereview.chromium.org/1242403002/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
(right):

https://codereview.chromium.org/1242403002/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc:237:

On 2015/07/21 at 20:46:22, scheib wrote:
> // Intentionally NOT adding a characteristic to generic_access service.

Done.

[ortuno, 2015-07-22 17:28:17]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-07-22 17:28:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1242403002/#ps80001
(title: "Add comment")

[commit-bot: I haz the power, 2015-07-22 17:28:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1242403002/80001

[commit-bot: I haz the power, 2015-07-22 17:59:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-22 17:59:53]

Patchset 5 (id:??) landed as
https://crrev.com/338cf0096006ea5bdefbbe2c0e4042698fde3b9c
Cr-Commit-Position: refs/heads/master@{#339912}