Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1227273005: bluetooth: Implement MissingServiceGenericAccessAdapter. (Closed)

Created:
5 years, 5 months ago by ortuno
Modified:
5 years, 5 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-tests-small-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Implement MissingServiceGenericAccessAdapter. Also implement ConnectableDevice and GenericAccessDevice. Part of the refactoring of the bluetooth test platform. Design doc: https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit# Three sided patch. See patch 1 for an explanation: [1] http://crrev.com/1243533004 [2] This patch. [3] http://crrev.com/1242103003 BUG=499552 Committed: https://crrev.com/9089e74de5746e4a6095993d93b77855be6e167a Cr-Commit-Position: refs/heads/master@{#339893}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Merge with ToT #

Total comments: 1

Patch Set 4 : Merge with ToT #

Patch Set 5 : Merged with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 2 3 4 2 chunks +35 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 2 3 4 chunks +45 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
ortuno
@jyasskin: PTAL
5 years, 5 months ago (2015-07-20 17:19:43 UTC) #2
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1227273005/diff/40001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): https://codereview.chromium.org/1227273005/diff/40001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h#newcode201 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:201: GetGenericAccessDevice( We may want this to be a ...
5 years, 5 months ago (2015-07-20 20:48:10 UTC) #3
ortuno
On 2015/07/20 at 20:48:10, jyasskin wrote: > lgtm > > https://codereview.chromium.org/1227273005/diff/40001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h > File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): ...
5 years, 5 months ago (2015-07-20 22:31:31 UTC) #4
scheib
LGTM
5 years, 5 months ago (2015-07-21 20:16:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227273005/80001
5 years, 5 months ago (2015-07-22 16:50:18 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-22 17:18:19 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:19:32 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9089e74de5746e4a6095993d93b77855be6e167a
Cr-Commit-Position: refs/heads/master@{#339893}

Powered by Google App Engine
This is Rietveld 408576698