Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1242383003: Split web_dev_style tests into separate files. (Closed)

Created:
5 years, 5 months ago by Dan Beam
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split web_dev_style tests into separate files. Should make adding new tests more manageable. R=tbreisacher@chromium.org BUG=none TEST=code is easier to comprehend Committed: https://crrev.com/a7b29129a2f4b266b18787c1981fc615c2053171 Cr-Commit-Position: refs/heads/master@{#339528}

Patch Set 1 : sys_path #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1101 lines, -996 lines) Patch
M chrome/browser/PRESUBMIT.py View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/test_presubmit.py View 1 1 chunk +16 lines, -991 lines 0 comments Download
A chrome/browser/web_dev_style/closure_lint_test.py View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/web_dev_style/css_checker_test.py View 1 1 chunk +416 lines, -0 lines 0 comments Download
A chrome/browser/web_dev_style/html_checker_test.py View 1 chunk +169 lines, -0 lines 0 comments Download
A chrome/browser/web_dev_style/js_checker_test.py View 1 chunk +329 lines, -0 lines 0 comments Download
A chrome/browser/web_dev_style/resource_checker_test.py View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/web_dev_style/test_util.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dan Beam
5 years, 5 months ago (2015-07-20 21:08:41 UTC) #4
Tyler Breisacher (Chromium)
lgtm
5 years, 5 months ago (2015-07-20 21:10:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242383003/60001
5 years, 5 months ago (2015-07-20 21:13:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/47095) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-20 21:16:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242383003/80001
5 years, 5 months ago (2015-07-20 21:23:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 5 months ago (2015-07-20 21:53:54 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 21:54:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7b29129a2f4b266b18787c1981fc615c2053171
Cr-Commit-Position: refs/heads/master@{#339528}

Powered by Google App Engine
This is Rietveld 408576698