Split web_dev_style tests into separate files.

chrome/browser/web_dev_style/css_checker_test.py

Index: chrome/browser/web_dev_style/css_checker_test.py
diff --git a/chrome/browser/web_dev_style/css_checker_test.py b/chrome/browser/web_dev_style/css_checker_test.py
new file mode 100755
index 0000000000000000000000000000000000000000..a9f8d49acf39f32ec94b67b02e06e63a421f3c61
--- /dev/null
+++ b/chrome/browser/web_dev_style/css_checker_test.py
@@ -0,0 +1,416 @@
+#!/usr/bin/env python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import css_checker
+from os import path as os_path
+import re
+from sys import path as sys_path
+import unittest
+
+_HERE = os_path.dirname(os_path.abspath(__file__))
+sys_path.append(os_path.join(_HERE, '..', '..', '..', 'tools'))
+
+import find_depot_tools  # pylint: disable=W0611
+from testing_support.super_mox import SuperMoxTestBase
+
+
+class CssCheckerTest(SuperMoxTestBase):
+  def setUp(self):
+    SuperMoxTestBase.setUp(self)
+
+    self.fake_file_name = 'fake.css'
+
+    self.fake_file = self.mox.CreateMockAnything()
+    self.mox.StubOutWithMock(self.fake_file, 'LocalPath')
+    self.fake_file.LocalPath().AndReturn(self.fake_file_name)
+    # Actual calls to NewContents() are defined in each test.
+    self.mox.StubOutWithMock(self.fake_file, 'NewContents')
+
+    self.input_api = self.mox.CreateMockAnything()
+    self.input_api.re = re
+    self.mox.StubOutWithMock(self.input_api, 'AffectedSourceFiles')
+    self.input_api.AffectedFiles(
+        include_deletes=False, file_filter=None).AndReturn([self.fake_file])
+
+    # Actual creations of PresubmitPromptWarning are defined in each test.
+    self.output_api = self.mox.CreateMockAnything()
+    self.mox.StubOutWithMock(self.output_api, 'PresubmitPromptWarning',
+                             use_mock_anything=True)
+
+    self.output_api = self.mox.CreateMockAnything()
+    self.mox.StubOutWithMock(self.output_api, 'PresubmitNotifyResult',
+                             use_mock_anything=True)
+
+  def VerifyContentsIsValid(self, contents):
+    self.fake_file.NewContents().AndReturn(contents.splitlines())
+    self.mox.ReplayAll()
+    css_checker.CSSChecker(self.input_api, self.output_api).RunChecks()
+
+  def VerifyContentsProducesOutput(self, contents, output):
+    self.fake_file.NewContents().AndReturn(contents.splitlines())
+    author_msg = ('Was the CSS checker useful? '
+                  'Send feedback or hate mail to dbeam@chromium.org.')
+    self.output_api.PresubmitNotifyResult(author_msg).AndReturn(None)
+    self.output_api.PresubmitPromptWarning(
+        self.fake_file_name + ':\n' + output.strip()).AndReturn(None)
+    self.mox.ReplayAll()
+    css_checker.CSSChecker(self.input_api, self.output_api).RunChecks()
+
+  def testCssAlphaWithAtBlock(self):
+    self.VerifyContentsProducesOutput("""
+<include src="../shared/css/cr/ui/overlay.css">
+<include src="chrome://resources/totally-cool.css" />
+
+/* A hopefully safely ignored comment and @media statement. /**/
+@media print {
+  div {
+    display: block;
+    color: red;
+  }
+}
+
+.rule {
+  z-index: 5;
+<if expr="not is macosx">
+  background-image: url(chrome://resources/BLAH); /* TODO(dbeam): Fix this. */
+  background-color: rgb(235, 239, 249);
+</if>
+<if expr="is_macosx">
+  background-color: white;
+  background-image: url(chrome://resources/BLAH2);
+</if>
+  color: black;
+}
+
+<if expr="is_macosx">
+.language-options-right {
+  visibility: hidden;
+  opacity: 1; /* TODO(dbeam): Fix this. */
+}
+</if>""", """
+- Alphabetize properties and list vendor specific (i.e. -webkit) above standard.
+    display: block;
+    color: red;
+
+    z-index: 5;
+    color: black;""")
+
+  def testCssStringWithAt(self):
+    self.VerifyContentsIsValid("""
+#logo {
+  background-image: url(images/google_logo.png@2x);
+}
+
+body.alternate-logo #logo {
+  -webkit-mask-image: url(images/google_logo.png@2x);
+  background: none;
+}
+
+.stuff1 {
+}
+
+.stuff2 {
+}
+      """)
+
+  def testCssAlphaWithNonStandard(self):
+    self.VerifyContentsProducesOutput("""
+div {
+  /* A hopefully safely ignored comment and @media statement. /**/
+  color: red;
+  -webkit-margin-start: 5px;
+}""", """
+- Alphabetize properties and list vendor specific (i.e. -webkit) above standard.
+    color: red;
+    -webkit-margin-start: 5px;""")
+
+  def testCssAlphaWithLongerDashedProps(self):
+    self.VerifyContentsProducesOutput("""
+div {
+  border-left: 5px;  /* A hopefully removed comment. */
+  border: 5px solid red;
+}""", """
+- Alphabetize properties and list vendor specific (i.e. -webkit) above standard.
+    border-left: 5px;
+    border: 5px solid red;""")
+
+  def testCssBracesHaveSpaceBeforeAndNothingAfter(self):
+    self.VerifyContentsProducesOutput("""
+/* Hello! */div/* Comment here*/{
+  display: block;
+}
+
+blah /* hey! */
+{
+  rule: value;
+}
+
+.this.is { /* allowed */
+  rule: value;
+}""", """
+- Start braces ({) end a selector, have a space before them and no rules after.
+    div{
+    {""")
+
+  def testCssClassesUseDashes(self):
+    self.VerifyContentsProducesOutput("""
+.className,
+.ClassName,
+.class-name /* We should not catch this. */,
+.class_name {
+  display: block;
+}""", """
+ - Classes use .dash-form.
+    .className,
+    .ClassName,
+    .class_name {""")
+
+  def testCssCloseBraceOnNewLine(self):
+    self.VerifyContentsProducesOutput("""
+@media { /* TODO(dbeam) Fix this case. */
+  .rule {
+    display: block;
+  }}
+
+@-webkit-keyframe blah {
+  from { height: rotate(-10turn); }
+  100% { height: 500px; }
+}
+
+#id { /* ${TemplateExpressions} should be ignored. */
+  rule: ${someValue};
+  --css-mixin: {
+    color: red;
+  };
+}
+
+#rule {
+  rule: value; }""", """
+- Always put a rule closing brace (}) on a new line.
+    rule: value; }""")
+
+  def testCssColonsHaveSpaceAfter(self):
+    self.VerifyContentsProducesOutput("""
+div:not(.class):not([attr=5]), /* We should not catch this. */
+div:not(.class):not([attr]) /* Nor this. */ {
+  background: url(data:image/jpeg,asdfasdfsadf); /* Ignore this. */
+  background: -webkit-linear-gradient(left, red,
+                                      80% blah blee blar);
+  color: red;
+  display:block;
+}""", """
+- Colons (:) should have a space after them.
+    display:block;
+
+- Don't use data URIs in source files. Use grit instead.
+    background: url(data:image/jpeg,asdfasdfsadf);""")
+
+  def testCssFavorSingleQuotes(self):
+    self.VerifyContentsProducesOutput("""
+html[dir="rtl"] body,
+html[dir=ltr] body /* TODO(dbeam): Require '' around rtl in future? */ {
+  font-family: "Open Sans";
+<if expr="is_macosx">
+  blah: blee;
+</if>
+}""", """
+- Use single quotes (') instead of double quotes (") in strings.
+    html[dir="rtl"] body,
+    font-family: "Open Sans";""")
+
+  def testCssHexCouldBeShorter(self):
+    self.VerifyContentsProducesOutput("""
+#abc,
+#abc-,
+#abc-ghij,
+#abcdef-,
+#abcdef-ghij,
+#aaaaaa,
+#bbaacc {
+  background-color: #336699; /* Ignore short hex rule if not gray. */
+  color: #999999;
+  color: #666;
+}""", """
+- Use abbreviated hex (#rgb) when in form #rrggbb.
+    color: #999999; (replace with #999)
+
+- Use rgb() over #hex when not a shade of gray (like #333).
+    background-color: #336699; (replace with rgb(51, 102, 153))""")
+
+  def testCssUseMillisecondsForSmallTimes(self):
+    self.VerifyContentsProducesOutput("""
+.transition-0s /* This is gross but may happen. */ {
+  transform: one 0.2s;
+  transform: two .1s;
+  transform: tree 1s;
+  transform: four 300ms;
+}""", """
+- Use milliseconds for time measurements under 1 second.
+    transform: one 0.2s; (replace with 200ms)
+    transform: two .1s; (replace with 100ms)""")
+
+  def testCssNoDataUrisInSourceFiles(self):
+    self.VerifyContentsProducesOutput("""
+img {
+  background: url( data:image/jpeg,4\/\/350|\/|3|2 );
+}""", """
+- Don't use data URIs in source files. Use grit instead.
+    background: url( data:image/jpeg,4\/\/350|\/|3|2 );""")
+
+  def testCssNoQuotesInUrl(self):
+    self.VerifyContentsProducesOutput("""
+img {
+  background: url('chrome://resources/images/blah.jpg');
+  background: url("../../folder/hello.png");
+}""", """
+- Use single quotes (') instead of double quotes (") in strings.
+    background: url("../../folder/hello.png");
+
+- Don't use quotes in url().
+    background: url('chrome://resources/images/blah.jpg');
+    background: url("../../folder/hello.png");""")
+
+  def testCssOneRulePerLine(self):
+    self.VerifyContentsProducesOutput("""
+a:not([hidden]):not(.custom-appearance):not([version=1]):first-of-type,
+a:not([hidden]):not(.custom-appearance):not([version=1]):first-of-type ~
+    input[type='checkbox']:not([hidden]),
+div {
+  background: url(chrome://resources/BLAH);
+  rule: value; /* rule: value; */
+  rule: value; rule: value;
+}""", """
+- One rule per line (what not to do: color: red; margin: 0;).
+    rule: value; rule: value;""")
+
+  def testCssOneSelectorPerLine(self):
+    self.VerifyContentsProducesOutput("""
+a,
+div,a,
+div,/* Hello! */ span,
+#id.class([dir=rtl):not(.class):any(a, b, d) {
+  rule: value;
+}
+
+a,
+div,a {
+  some-other: rule here;
+}""", """
+- One selector per line (what not to do: a, b {}).
+    div,a,
+    div, span,
+    div,a {""")
+
+  def testCssPseudoElementDoubleColon(self):
+    self.VerifyContentsProducesOutput("""
+a:href,
+br::after,
+::-webkit-scrollbar-thumb,
+a:not([empty]):hover:focus:active, /* shouldn't catch here and above */
+abbr:after,
+.tree-label:empty:after,
+b:before,
+:-WebKit-ScrollBar {
+  rule: value;
+}""", """
+- Pseudo-elements should use double colon (i.e. ::after).
+    :after (should be ::after)
+    :after (should be ::after)
+    :before (should be ::before)
+    :-WebKit-ScrollBar (should be ::-WebKit-ScrollBar)
+    """)
+
+  def testCssRgbIfNotGray(self):
+    self.VerifyContentsProducesOutput("""
+#abc,
+#aaa,
+#aabbcc {
+  background: -webkit-linear-gradient(left, from(#abc), to(#def));
+  color: #bad;
+  color: #bada55;
+}""", """
+- Use rgb() over #hex when not a shade of gray (like #333).
+    background: -webkit-linear-gradient(left, from(#abc), to(#def)); """
+"""(replace with rgb(170, 187, 204), rgb(221, 238, 255))
+    color: #bad; (replace with rgb(187, 170, 221))
+    color: #bada55; (replace with rgb(186, 218, 85))""")
+
+  def testWebkitBeforeOrAfter(self):
+    self.VerifyContentsProducesOutput("""
+.test {
+  -webkit-margin-before: 10px;
+  -webkit-margin-start: 20px;
+  -webkit-padding-after: 3px;
+  -webkit-padding-end: 5px;
+}
+""", """
+- Use *-top/bottom instead of -webkit-*-before/after.
+    -webkit-margin-before: 10px; (replace with margin-top)
+    -webkit-padding-after: 3px; (replace with padding-bottom)""")
+
+  def testCssZeroWidthLengths(self):
+    self.VerifyContentsProducesOutput("""
+@-webkit-keyframe anim {
+  0% { /* Ignore key frames */
+    width: 0px;
+  }
+  10% {
+    width: 10px;
+  }
+  100% {
+    width: 100px;
+  }
+}
+
+#logo {
+  background-image: url(images/google_logo.png@2x);
+}
+
+body.alternate-logo #logo {
+  -webkit-mask-image: url(images/google_logo.png@2x);
+}
+
+/* http://crbug.com/359682 */
+#spinner-container #spinner {
+  -webkit-animation-duration: 1.0s;
+}
+
+.media-button.play > .state0.active,
+.media-button[state='0'] > .state0.normal /* blah */, /* blee */
+.media-button[state='0']:not(.disabled):hover > .state0.hover {
+  -webkit-animation: anim 0s;
+  -webkit-animation-duration: anim 0ms;
+  -webkit-transform: scale(0%);
+  background-position-x: 0em;
+  background-position-y: 0ex;
+  border-width: 0em;
+  color: hsl(0, 0%, 85%); /* Shouldn't trigger error. */
+  opacity: .0;
+  opacity: 0.0;
+  opacity: 0.;
+}
+
+@page {
+  border-width: 0mm;
+  height: 0cm;
+  width: 0in;
+}""", """
+- Use "0" for zero-width lengths (i.e. 0px -> 0)
+    width: 0px;
+    -webkit-transform: scale(0%);
+    background-position-x: 0em;
+    background-position-y: 0ex;
+    border-width: 0em;
+    opacity: .0;
+    opacity: 0.0;
+    opacity: 0.;
+    border-width: 0mm;
+    height: 0cm;
+    width: 0in;
+""")
+
+
+if __name__ == '__main__':
+  unittest.main()