Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1242343002: Remove more uses of Isolate::current_zone. (Closed)

Created:
5 years, 5 months ago by koda
Modified:
5 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove more uses of Isolate::current_zone. The most substantial change is in Parser and ParsedFunction, which now cache their calling thread. (A similar change was tried unsuccessfully in the past, but can now be safely implemented thanks to the ThreadRegistry state saving.) Only remaining users are the Object::Handle(Isolate*, [...]) methods. Then, this deprecated interface will be removed. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/700bd543620e38cc336da1c13e7dc69317eb6d31

Patch Set 1 #

Total comments: 2

Patch Set 2 : Access isolate via thread. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -48 lines) Patch
M runtime/vm/dart_api_impl.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_state.h View 4 chunks +20 lines, -20 lines 0 comments Download
M runtime/vm/handles.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/handles_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/native_entry.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/parser.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 5 months ago (2015-07-20 15:43:39 UTC) #2
siva
LGTM with one comment. https://codereview.chromium.org/1242343002/diff/1/runtime/vm/parser.h File runtime/vm/parser.h (right): https://codereview.chromium.org/1242343002/diff/1/runtime/vm/parser.h#newcode814 runtime/vm/parser.h:814: Isolate* isolate_; // Cached current ...
5 years, 5 months ago (2015-07-21 15:47:20 UTC) #3
koda
https://codereview.chromium.org/1242343002/diff/1/runtime/vm/parser.h File runtime/vm/parser.h (right): https://codereview.chromium.org/1242343002/diff/1/runtime/vm/parser.h#newcode814 runtime/vm/parser.h:814: Isolate* isolate_; // Cached current isolate. On 2015/07/21 15:47:20, ...
5 years, 5 months ago (2015-07-21 16:29:29 UTC) #4
koda
5 years, 5 months ago (2015-07-21 16:37:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
700bd543620e38cc336da1c13e7dc69317eb6d31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698