Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: runtime/vm/dart_api_state.h

Issue 1242343002: Remove more uses of Isolate::current_zone. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Access isolate via thread. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/handles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_state.h
diff --git a/runtime/vm/dart_api_state.h b/runtime/vm/dart_api_state.h
index 4f2935409941f9de21e87234200e771d9a31995d..207aab425acc18a57be1f76b807d2252c6db02ad 100644
--- a/runtime/vm/dart_api_state.h
+++ b/runtime/vm/dart_api_state.h
@@ -35,11 +35,11 @@ class ApiZone {
public:
// Create an empty zone.
ApiZone() : zone_() {
- Isolate* isolate = Isolate::Current();
- Zone* current_zone = isolate != NULL ? isolate->current_zone() : NULL;
- zone_.Link(current_zone);
- if (isolate != NULL) {
- isolate->set_current_zone(&zone_);
+ Thread* thread = Thread::Current();
+ Zone* zone = thread != NULL ? thread->zone() : NULL;
+ zone_.Link(zone);
+ if (thread != NULL) {
+ thread->set_zone(&zone_);
}
#ifdef DEBUG
if (FLAG_trace_zones) {
@@ -52,15 +52,15 @@ class ApiZone {
// Delete all memory associated with the zone.
~ApiZone() {
- Isolate* isolate = Isolate::Current();
+ Thread* thread = Thread::Current();
#if defined(DEBUG)
- if (isolate == NULL) {
+ if (thread == NULL) {
ASSERT(zone_.handles()->CountScopedHandles() == 0);
ASSERT(zone_.handles()->CountZoneHandles() == 0);
}
#endif
- if ((isolate != NULL) && (isolate->current_zone() == &zone_)) {
- isolate->set_current_zone(zone_.previous_);
+ if ((thread != NULL) && (thread->zone() == &zone_)) {
+ thread->set_zone(zone_.previous_);
}
#ifdef DEBUG
if (FLAG_trace_zones) {
@@ -101,18 +101,18 @@ class ApiZone {
Zone* GetZone() { return &zone_; }
- void Reinit(Isolate* isolate) {
- if (isolate == NULL) {
+ void Reinit(Thread* thread) {
+ if (thread == NULL) {
zone_.Link(NULL);
} else {
- zone_.Link(isolate->current_zone());
- isolate->set_current_zone(&zone_);
+ zone_.Link(thread->zone());
+ thread->set_zone(&zone_);
}
}
- void Reset(Isolate* isolate) {
- if ((isolate != NULL) && (isolate->current_zone() == &zone_)) {
- isolate->set_current_zone(zone_.previous_);
+ void Reset(Thread* thread) {
+ if ((thread != NULL) && (thread->zone() == &zone_)) {
+ thread->set_zone(zone_.previous_);
}
zone_.DeleteAll();
}
@@ -592,16 +592,16 @@ class ApiLocalScope {
}
// Reinit the ApiLocalScope to new values.
- void Reinit(Isolate* isolate, ApiLocalScope* previous, uword stack_marker) {
+ void Reinit(Thread* thread, ApiLocalScope* previous, uword stack_marker) {
previous_ = previous;
stack_marker_ = stack_marker;
- zone_.Reinit(isolate);
+ zone_.Reinit(thread);
}
// Reset the ApiLocalScope so that it can be reused again.
- void Reset(Isolate* isolate) {
+ void Reset(Thread* thread) {
local_handles_.Reset();
- zone_.Reset(isolate);
+ zone_.Reset(thread);
previous_ = NULL;
stack_marker_ = 0;
}
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698