Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 12422019: ES6 symbols: prevent reflection and proxy APIs from leaking symbols (Closed)

Created:
7 years, 9 months ago by rossberg
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

ES6 symbols: prevent reflection, proxy, and observe APIs from leaking symbols R=svenpanne@chromium.org BUG=v8:2158 Committed: http://code.google.com/p/v8/source/detail?r=14056

Patch Set 1 #

Patch Set 2 : Use the right diff #

Patch Set 3 : Deal with Object.observe as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -32 lines) Patch
M src/d8.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/object-observe.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.cc View 11 chunks +34 lines, -6 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/v8natives.js View 1 2 9 chunks +23 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 2 2 chunks +24 lines, -1 line 0 comments Download
A test/mjsunit/harmony/proxies-symbols.js View 1 chunk +106 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sven Panne
7 years, 9 months ago (2013-03-22 12:40:45 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698