src/mirror-debugger.js - Issue 12422019: ES6 symbols: prevent reflection and proxy APIs from leaking symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mirror-debugger.js

Issue 12422019: ES6 symbols: prevent reflection and proxy APIs from leaking symbols (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Deal with Object.observe as well Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mirror-debugger.js

diff --git a/src/mirror-debugger.js b/src/mirror-debugger.js

index 7f1a05aed9479e8b8cb0d12cf7777bcea1eae73c..e1fd872f3b980f0224bb3b1741989ea3dcea2718 100644

--- a/src/mirror-debugger.js

+++ b/src/mirror-debugger.js

@@ -638,7 +638,7 @@ ObjectMirror.prototype.propertyNames = function(kind, limit) {

// Find all the named properties.

if (kind & PropertyKind.Named) {

// Get the local property names.

- propertyNames = %GetLocalPropertyNames(this.value_);

+ propertyNames = %GetLocalPropertyNames(this.value_, true);

total += propertyNames.length;

// Get names for named interceptor properties if any.

« no previous file with comments | « src/heap.cc ('k') | src/object-observe.js » ('j') | no next file with comments »