Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
12422013:
Output the size of npchrome_frame.dll during the sizes step for inclusion in the sizes perf dashboa… (Closed)
|
Created:
7 years, 9 months ago by grt (UTC plus 2) Modified:
7 years, 9 months ago CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org Base URL:
http://src.chromium.org/svn/trunk/tools/ Visibility:
Public. |
DescriptionOutput the size of npchrome_frame.dll during the sizes step for inclusion in the sizes perf dashboard.
BUG=222370
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189814
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 8 (0 generated)
Hi Robert, I'm taking a stab at adding a new binary to the xp-release sizes dashboard/test. Please have a look. https://codereview.chromium.org/12950007 contains my attempt to get the new result emitted by this CL onto the dashboard. I will also submit a change to Chrome's tools/perf_expectations/perf_expectations.json. For the latter, I guess I need to wait until there are some results so that make_expectations.py can do its thing. Please let me know if I've missed something else that needs to be added/adjusted to get npchrome_frame.dll on sizes and closing the tree. And, of course, redirect at will if someone else is better suited to review. Thanks.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/12422013/1
Presubmit check for 12422013-1 failed and returned exit status 1. INFO:root:Found 1 file(s). INFO:PRESUBMIT:Running pylint on 314 files 49 masters succeeded, 0 failed, 12 skipped in 196.3s. Trying master.chromium Trying master.chromium.chrome Trying master.chromium.chromebot Trying master.chromium.chromiumos Trying master.chromium.endure Trying master.chromium.flaky Trying master.chromium.fyi Trying master.chromium.gatekeeper Trying master.chromium.git Trying master.chromium.gpu Trying master.chromium.gpu.fyi Trying master.chromium.linux Trying master.chromium.lkgr Trying master.chromium.mac Trying master.chromium.memory Trying master.chromium.memory.fyi Trying master.chromium.perf Trying master.chromium.perf_av Trying master.chromium.pyauto Trying master.chromium.swarm Trying master.chromium.webkit Trying master.chromium.webrtc Trying master.chromium.webrtc.fyi Trying master.chromium.win Trying master.chromiumos Trying master.client.dart Trying master.client.dart.fyi Trying master.client.drmemory Trying master.client.dynamorio Trying master.client.libjingle Trying master.client.libyuv Trying master.client.nacl Trying master.client.nacl.chrome Trying master.client.nacl.llvm Trying master.client.nacl.ports Trying master.client.nacl.ragel Trying master.client.nacl.sdk Trying master.client.nacl.sdk.addin Trying master.client.nacl.sdk.mono Trying master.client.nacl.toolchain Trying master.client.omaha Trying master.client.pagespeed Trying master.client.v8 Trying master.client.webrtc Trying master.devtools Trying master.tryserver.chromium Trying master.tryserver.chromium.linux Trying master.tryserver.nacl Trying master.tryserver.webrtc /b/commit-queue/workdir/tools/build/third_party/zope/__init__.py:19: UserWarning: Module mock was already imported from /b/commit-queue/workdir/tools/build/third_party/mock-1.0.1/mock.py, but /usr/local/lib/python2.6/dist-packages/mock-1.0b1-py2.6.egg is being added to sys.path import pkg_resources test_android (__main__.TestMailNotifier) ... ok test_cq_succeed (__main__.TestMailNotifier) ... ok test_simple (__main__.TestMailNotifier) ... ok ---------------------------------------------------------------------- Ran 3 tests in 0.255s OK Parsing client.v8 Parsing chromium.endure Parsing chromium.memory Skipping chromium.swarm, fix and enable in masters_cfg_test.py! Skipping client.nacl.chrome, fix and enable in masters_cfg_test.py! Parsing experimental Parsing chromium.win Parsing client.skia Parsing chromium Parsing tryserver.webrtc WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" Parsing client.sfntly Parsing chromium.webrtc Parsing client.dart.fyi Parsing chromium.webrtc.fyi Parsing client.pagespeed Parsing chromium.pyauto Parsing client.libjingle WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" Parsing tryserver.chromium WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/out" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/out" WARNING: Passed "src/build" as --build-dir option on darwin. This is almost certainly incorrect. Assuming you meant "src/out" WARNING: Passed "src/build" as --build-dir option on darwin. This is almost certainly incorrect. Assuming you meant "src/out" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. Assuming you meant "src/sconsbuild" WARNING: Passed "src/build" as --bui… (message too large)
I suspect the presubmit error is transient. I'd give it another whirl. On Thu, Mar 21, 2013 at 1:06 PM, <commit-bot@chromium.org> wrote: > Presubmit check for 12422013-1 failed and returned exit status 1. > > INFO:root:Found 1 file(s). > INFO:PRESUBMIT:Running pylint on 314 files > 49 masters succeeded, 0 failed, 12 skipped in 196.3s. > Trying master.chromium > Trying master.chromium.chrome > Trying master.chromium.chromebot > Trying master.chromium.chromiumos > Trying master.chromium.endure > Trying master.chromium.flaky > Trying master.chromium.fyi > Trying master.chromium.gatekeeper > Trying master.chromium.git > Trying master.chromium.gpu > Trying master.chromium.gpu.fyi > Trying master.chromium.linux > Trying master.chromium.lkgr > Trying master.chromium.mac > Trying master.chromium.memory > Trying master.chromium.memory.fyi > Trying master.chromium.perf > Trying master.chromium.perf_av > Trying master.chromium.pyauto > Trying master.chromium.swarm > Trying master.chromium.webkit > Trying master.chromium.webrtc > Trying master.chromium.webrtc.fyi > Trying master.chromium.win > Trying master.chromiumos > Trying master.client.dart > Trying master.client.dart.fyi > Trying master.client.drmemory > Trying master.client.dynamorio > Trying master.client.libjingle > Trying master.client.libyuv > Trying master.client.nacl > Trying master.client.nacl.chrome > Trying master.client.nacl.llvm > Trying master.client.nacl.ports > Trying master.client.nacl.ragel > Trying master.client.nacl.sdk > Trying master.client.nacl.sdk.addin > Trying master.client.nacl.sdk.mono > Trying master.client.nacl.toolchain > Trying master.client.omaha > Trying master.client.pagespeed > Trying master.client.v8 > Trying master.client.webrtc > Trying master.devtools > Trying master.tryserver.chromium > Trying master.tryserver.chromium.**linux > Trying master.tryserver.nacl > Trying master.tryserver.webrtc > /b/commit-queue/workdir/tools/**build/third_party/zope/__init_**_.py:19: > UserWarning: Module mock was already imported from > /b/commit-queue/workdir/tools/**build/third_party/mock-1.0.1/**mock.py, > but > /usr/local/lib/python2.6/dist-**packages/mock-1.0b1-py2.6.egg is being > added to > sys.path > import pkg_resources > test_android (__main__.TestMailNotifier) ... ok > test_cq_succeed (__main__.TestMailNotifier) ... ok > test_simple (__main__.TestMailNotifier) ... ok > > ------------------------------**------------------------------**---------- > Ran 3 tests in 0.255s > > OK > Parsing client.v8 > Parsing chromium.endure > Parsing chromium.memory > Skipping chromium.swarm, fix and enable in masters_cfg_test.py! > Skipping client.nacl.chrome, fix and enable in masters_cfg_test.py! > Parsing experimental > Parsing chromium.win > Parsing client.skia > Parsing chromium > Parsing tryserver.webrtc > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > Parsing client.sfntly > Parsing chromium.webrtc > Parsing client.dart.fyi > Parsing chromium.webrtc.fyi > Parsing client.pagespeed > Parsing chromium.pyauto > Parsing client.libjingle > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > Parsing tryserver.chromium > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on darwin. This is almost > certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on darwin. This is almost > certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost > certainly incorrect. > Assuming you meant "src/sconsbuild" > WARNING: Passed "src/build" as --bui… > (message too large) > > https://chromiumcodereview.**appspot.com/12422013/<https://chromiumcodereview... >
sorry for late lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/12422013/8001
Message was sent while issue was closed.
Change committed as 189814 |
