Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1242043002:
Selectable number of TL screenshare loopback test (Closed)
|
Created:
5 years, 5 months ago by sprang_webrtc Modified:
5 years, 4 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionSelectable number of TL screenshare loopback test. Also contains some tweaks to make a single TL perform better.
BUG=
Committed: https://crrev.com/ef7228cfa00cd6eb72754e923b1ac7348c1dfb22
Cr-Commit-Position: refs/heads/master@{#9676}
Patch Set 1 #Patch Set 2 : Rebase, cleanup #Patch Set 3 : Updated test case #
Total comments: 2
Patch Set 4 : Allow referencing all buffers for single TL #Patch Set 5 : Cast needed for msvc #
Messages
Total messages: 27 (12 generated)
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
sprang@webrtc.org changed reviewers: + stefan@webrtc.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242043002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/4930) ios_arm64 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64/builds/3689) linux on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux/builds/8862) linux_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn/builds/4883) linux_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/4839) linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8697) linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/6052) win_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/8859) win_x64_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn/builds/3278)
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242043002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8699)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242043002/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
stefan@webrtc.org changed reviewers: + stefan@webrtc.org
https://codereview.webrtc.org/1242043002/diff/40001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right): https://codereview.webrtc.org/1242043002/diff/40001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:70: return kTl0Flags; What does this change mean? That we constrain the stream to not use all reference buffers if doing 1 layer screenshare? That seems bad to me.
https://codereview.webrtc.org/1242043002/diff/40001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc (right): https://codereview.webrtc.org/1242043002/diff/40001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc:70: return kTl0Flags; On 2015/08/04 14:40:28, stefan-webrtc (holmer) wrote: > What does this change mean? That we constrain the stream to not use all > reference buffers if doing 1 layer screenshare? That seems bad to me. Yes. This was a hack I did to get overshoot detection to work, but that should be solved in libvpx instead. Reverted.
lgtm
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242043002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242043002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/8661)
The CQ bit was checked by sprang@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/1242043002/#ps80001 (title: "Cast needed for msvc")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1242043002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1242043002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/ef7228cfa00cd6eb72754e923b1ac7348c1dfb22 Cr-Commit-Position: refs/heads/master@{#9676} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
