Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1241923002: Fix for android command line arguments to VisualBench (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for android command line arguments to VisualBench BUG=skia: Committed: https://skia.googlesource.com/skia/+/dcd56e2f0e1bd31f260d19873be485340b66f096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M platform_tools/android/bin/android_launch_app View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/visualbench/jni/main.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
ptal, I found that command line arguments were getting 'lost' to visual bench. Surrounding the ...
5 years, 5 months ago (2015-07-15 16:34:59 UTC) #2
tomhudson
On 2015/07/15 16:34:59, joshualitt wrote: > ptal, I found that command line arguments were getting ...
5 years, 5 months ago (2015-07-15 17:07:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241923002/1
5 years, 5 months ago (2015-07-15 17:09:01 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 17:17:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dcd56e2f0e1bd31f260d19873be485340b66f096

Powered by Google App Engine
This is Rietveld 408576698