platform_tools/android/bin/android_launch_app - Issue 1241923002: Fix for android command line arguments to VisualBench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/bin/android_launch_app

Issue 1241923002: Fix for android command line arguments to VisualBench (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/bin/android_launch_app

diff --git a/platform_tools/android/bin/android_launch_app b/platform_tools/android/bin/android_launch_app

index 53b00e902312e6a5ccfbb7c2829fb76d8c81d855..3eddf3547e29efba4df2d4df48ce1d38237f88dd 100755

--- a/platform_tools/android/bin/android_launch_app

+++ b/platform_tools/android/bin/android_launch_app

@@ -21,7 +21,7 @@ fi

if [[ ${app} == 'SampleApp' ]]; then

$ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.SkiaSampleActivity" --es "cmdLineFlags" "${APP_ARGS[*]:1}"

elif [[ ${app} == "VisualBench" ]] ; then

- $ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.VisualBenchActivity" --es "cmdLineFlags" "${APP_ARGS[*]:1}"

+ $ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.VisualBenchActivity" --es "cmdLineFlags" \"${APP_ARGS[*]:1}\"

else

echo "ERROR: supports either 'SampleApp' or 'VisualBench' as valid apps"

« no previous file with comments | « no previous file | platform_tools/android/visualbench/jni/main.cpp » ('j') | no next file with comments »