Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 124183002: Implement delete methods for the various CannedBrowsingDataHelpers. (Closed)

Created:
6 years, 11 months ago by Robert Sesek
Modified:
6 years, 11 months ago
Reviewers:
markusheintz_, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Implement delete methods for the various CannedBrowsingDataHelpers. This will allow individual cookies and other site data to be deleted via the CookieTreeModel GUI. As a result of this change, updates to the various storage systems will be pushed to the canned helpers after creation of the CookieTreeModel. Also removes a pimpl for BrowsingDataIndexedDBHelper since no other canned helpers followed this pattern. BUG=168996 TEST=No visible changes yet. Deleters covered by unit tests. TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243315

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : CollectedCookiesTest.DoubleDisplay #

Patch Set 4 : Self-nit #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -195 lines) Patch
M chrome/browser/browsing_data/browsing_data_appcache_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_appcache_helper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.cc View 1 2 3 3 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.h View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 2 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.h View 1 2 3 chunks +38 lines, -29 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 2 8 chunks +32 lines, -87 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc View 2 chunks +44 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper.cc View 1 2 3 2 chunks +14 lines, -23 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
6 years, 11 months ago (2014-01-03 22:43:46 UTC) #1
markusheintz_
LGTM Thanks a thousand times for getting started on this!! This is really great.
6 years, 11 months ago (2014-01-07 12:51:12 UTC) #2
Robert Sesek
TBRing dbeam@ OWNERS for a one-line change in chrome/browser/ui/webui/options/. On 2014/01/07 12:51:12, markusheintz_ wrote: > ...
6 years, 11 months ago (2014-01-07 14:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/124183002/280001
6 years, 11 months ago (2014-01-07 14:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/124183002/280001
6 years, 11 months ago (2014-01-07 15:30:44 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 17:08:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 243315

Powered by Google App Engine
This is Rietveld 408576698