Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/browsing_data/browsing_data_local_storage_helper.cc

Issue 124183002: Implement delete methods for the various CannedBrowsingDataHelpers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
diff --git a/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc b/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
index b906a79a4e39b9d7602541069ddbcaac4fbc1e13..21316c3c706708d88dc20d29819b91e8f7e57503 100644
--- a/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
+++ b/chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/browsing_data/browsing_data_local_storage_helper.h"
#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/browser_thread.h"
@@ -121,31 +120,23 @@ CannedBrowsingDataLocalStorageHelper::GetLocalStorageInfo() const {
void CannedBrowsingDataLocalStorageHelper::StartFetching(
const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback) {
- DCHECK(!is_fetching_);
- DCHECK_EQ(false, callback.is_null());
-
- is_fetching_ = true;
- completion_callback_ = callback;
-
- // We post a task to emulate async fetching behavior.
- base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(&CannedBrowsingDataLocalStorageHelper::ConvertPendingInfo,
- this));
-}
-
-CannedBrowsingDataLocalStorageHelper::~CannedBrowsingDataLocalStorageHelper() {}
-
-void CannedBrowsingDataLocalStorageHelper::ConvertPendingInfo() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- local_storage_info_.clear();
+ DCHECK(!callback.is_null());
+
+ std::list<LocalStorageInfo> result;
for (std::set<GURL>::iterator iter = pending_local_storage_info_.begin();
iter != pending_local_storage_info_.end(); ++iter) {
- local_storage_info_.push_back(
+ result.push_back(
LocalStorageInfo(*iter, 0, base::Time()));
}
- base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(&CannedBrowsingDataLocalStorageHelper::CallCompletionCallback,
- this));
+
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE, base::Bind(callback, result));
}
+
+void CannedBrowsingDataLocalStorageHelper::DeleteOrigin(const GURL& origin) {
+ pending_local_storage_info_.erase(origin);
+ BrowsingDataLocalStorageHelper::DeleteOrigin(origin);
+}
+
+CannedBrowsingDataLocalStorageHelper::~CannedBrowsingDataLocalStorageHelper() {}

Powered by Google App Engine
This is Rietveld 408576698