Async Safe Browsing check, on mobile

chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc

Index: chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc
diff --git a/chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc b/chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc
index 6bda059f50c37b77e406f267a5de06c4b66e217e..a9ba6666c1277d16800135841b04c8049fc90261 100644
--- a/chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc
+++ b/chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc
@@ -43,10 +43,13 @@ DataReductionProxyResourceThrottleFactory::CreateResourceThrottle(
     content::ResourceType resource_type,
     SafeBrowsingService* service) {
 #if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
+  // Send requests through Safe Browsing if we can't process them.
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
   if (io_data->IsOffTheRecord() || !io_data->IsDataReductionProxyEnabled() ||
-      request->url().SchemeIsSecure())
-    return new SafeBrowsingResourceThrottle(request, resource_type, service);
+      request->url().SchemeIsSecure()) {
+    return SafeBrowsingResourceThrottleFactory::CreateWithoutFactory(

[mattm, 2015/07/24 23:24:11]

This is kinda confusing at first glance.. maybe have a comment like
"DataReductionProxyResourceThrottleFactory is registered as the
SafeBrowsingResourceThrottleFactory, so need to bypass that and use the base
SafeBrowsingResourceThrottleFactory".

Also the naming SafeBrowsingResourceThrottleFactory::CreateWithoutFactory is not
really obvious what CreateWithoutFactory means when the class has Factory in the
name :) Maybe CreateWithoutRegisteredFactory or something?

As an alternative approach, maybe if the registered factory returns NULL, then
the base factory could just fall back to the base behavior? Guess that could be
confusing since NULL could in theory be a valid result, though there isn't
currently a need for that..

[Nathan Parker, 2015/07/28 17:42:12]

Done.

+        request, resource_type, service);
+  }
 #endif
   return new DataReductionProxyResourceThrottle(request, resource_type,
                                                 service);