Async Safe Browsing check, on mobile

chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.h"
 
 #include "base/logging.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h"
@@ skipping 25 matching lines @@
 const char* DataReductionProxyResourceThrottle::kUnsafeUrlProceedHeader =
       "X-Unsafe-Url-Proceed";
 
 ResourceThrottle*
 DataReductionProxyResourceThrottleFactory::CreateResourceThrottle(
     net::URLRequest* request,
     content::ResourceContext* resource_context,
     content::ResourceType resource_type,
     SafeBrowsingService* service) {
 #if defined(SAFE_BROWSING_DB_LOCAL) || defined(SAFE_BROWSING_DB_REMOTE)
+  // Send requests through Safe Browsing if we can't process them.
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
   if (io_data->IsOffTheRecord() || !io_data->IsDataReductionProxyEnabled() ||
-      request->url().SchemeIsSecure())
-    return new SafeBrowsingResourceThrottle(request, resource_type, service);
+      request->url().SchemeIsSecure()) {
+    return SafeBrowsingResourceThrottleFactory::CreateWithoutFactory(

[mattm, 2015/07/24 23:24:11]

This is kinda confusing at first glance.. maybe have a comment like
"DataReductionProxyResourceThrottleFactory is registered as the
SafeBrowsingResourceThrottleFactory, so need to bypass that and use the base
SafeBrowsingResourceThrottleFactory".

Also the naming SafeBrowsingResourceThrottleFactory::CreateWithoutFactory is not
really obvious what CreateWithoutFactory means when the class has Factory in the
name :) Maybe CreateWithoutRegisteredFactory or something?

As an alternative approach, maybe if the registered factory returns NULL, then
the base factory could just fall back to the base behavior? Guess that could be
confusing since NULL could in theory be a valid result, though there isn't
currently a need for that..

[Nathan Parker, 2015/07/28 17:42:12]

Done.

+        request, resource_type, service);
+  }
 #endif
   return new DataReductionProxyResourceThrottle(request, resource_type,
                                                 service);
 }
 
 DataReductionProxyResourceThrottle::DataReductionProxyResourceThrottle(
     net::URLRequest* request,
     content::ResourceType resource_type,
     SafeBrowsingService* safe_browsing)
     : state_(STATE_NONE),
@@ skipping 112 matching lines @@
   return result;
 }
 
 void DataReductionProxyResourceThrottle::ResumeRequest() {
   CHECK(state_ == STATE_NONE);
 
   // Inject the header before resuming the request.
   request_->SetExtraRequestHeaderByName(kUnsafeUrlProceedHeader, "1", true);
   controller()->Resume();
 }