Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1241533004: Revert of Expose SIMD.Float32x4 type to Javascript. (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 5 months ago
CC:
v8-dev, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001 of https://codereview.chromium.org/1219943002/) Reason for revert: Seems to brake the latest roll into Chromium: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/59796/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Expose SIMD.Float32x4 type to Javascript. > This CL exposes the constructor function, defines type related > information, and implements value type semantics. > It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. > > TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc > > LOG=Y > BUG=v8:4124 > > Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 > Cr-Commit-Position: refs/heads/master@{#29689} TBR=rossberg@chromium.org,littledan@chromium.org,martyn.capewell@arm.com,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/40c38c5a5a14471e88f4e7a31660f4908bd8fdf7 Cr-Commit-Position: refs/heads/master@{#29701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -1185 lines) Patch
M BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M include/v8.h View 6 chunks +1 line, -51 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-stubs.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +12 lines, -20 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
D src/harmony-simd.js View 1 chunk +0 lines, -89 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/macros.py View 2 chunks +0 lines, -2 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 4 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 8 chunks +4 lines, -39 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/runtime.js View 11 chunks +5 lines, -23 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -11 lines 0 comments Download
D src/runtime/runtime-simd.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/types.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +22 lines, -33 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D test/cctest/test-simd.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D test/mjsunit/harmony/simd.js View 1 chunk +0 lines, -408 lines 0 comments Download
M test/mjsunit/messages.js View 2 chunks +1 line, -6 lines 0 comments Download
M test/mjsunit/samevalue.js View 1 chunk +59 lines, -75 lines 0 comments Download
M test/simdjs/harness-adapt.js View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of Expose SIMD.Float32x4 type to Javascript.
5 years, 5 months ago (2015-07-16 12:35:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241533004/1
5 years, 5 months ago (2015-07-16 12:35:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 12:36:03 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 12:36:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40c38c5a5a14471e88f4e7a31660f4908bd8fdf7
Cr-Commit-Position: refs/heads/master@{#29701}

Powered by Google App Engine
This is Rietveld 408576698