Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: src/objects.cc

Issue 1241533004: Revert of Expose SIMD.Float32x4 type to Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index efe35ed30ecab035dc602df3b821b8f9002fd238..4fdb63dd877e5510e13d8dc9d49a6a071b5eaefa 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -81,8 +81,6 @@
constructor = handle(native_context->string_function(), isolate);
} else if (object->IsSymbol()) {
constructor = handle(native_context->symbol_function(), isolate);
- } else if (object->IsFloat32x4()) {
- constructor = handle(native_context->float32x4_function(), isolate);
} else {
return MaybeHandle<JSReceiver>();
}
@@ -607,7 +605,7 @@
HeapObject* heap_object = HeapObject::cast(this);
- // The object is either a number, a string, a symbol, a boolean, a SIMD value,
+ // The object is either a number, a string, a boolean,
// a real JS object, or a Harmony proxy.
if (heap_object->IsJSReceiver()) {
return heap_object->map();
@@ -626,9 +624,6 @@
if (heap_object->IsBoolean()) {
return context->boolean_function()->initial_map();
}
- if (heap_object->IsFloat32x4()) {
- return context->float32x4_function()->initial_map();
- }
return isolate->heap()->null_value()->map();
}
@@ -644,7 +639,7 @@
Object* Object::GetSimpleHash() {
// The object is either a Smi, a HeapNumber, a name, an odd-ball,
- // a SIMD value type, a real JS object, or a Harmony proxy.
+ // a real JS object, or a Harmony proxy.
if (IsSmi()) {
uint32_t hash = ComputeIntegerHash(Smi::cast(this)->value(), kZeroHashSeed);
return Smi::FromInt(hash & Smi::kMaxValue);
@@ -667,16 +662,6 @@
uint32_t hash = Oddball::cast(this)->to_string()->Hash();
return Smi::FromInt(hash);
}
- if (IsFloat32x4()) {
- Float32x4* simd = Float32x4::cast(this);
- uint32_t seed = v8::internal::kZeroHashSeed;
- uint32_t hash;
- hash = ComputeIntegerHash(bit_cast<uint32_t>(simd->get_lane(0)), seed);
- hash = ComputeIntegerHash(bit_cast<uint32_t>(simd->get_lane(1)), hash * 31);
- hash = ComputeIntegerHash(bit_cast<uint32_t>(simd->get_lane(2)), hash * 31);
- hash = ComputeIntegerHash(bit_cast<uint32_t>(simd->get_lane(3)), hash * 31);
- return Smi::FromInt(hash & Smi::kMaxValue);
- }
DCHECK(IsJSReceiver());
JSReceiver* receiver = JSReceiver::cast(this);
return receiver->GetHeap()->undefined_value();
@@ -703,14 +688,6 @@
if (IsString() && other->IsString()) {
return String::cast(this)->Equals(String::cast(other));
}
- if (IsFloat32x4() && other->IsFloat32x4()) {
- Float32x4* x = Float32x4::cast(this);
- Float32x4* y = Float32x4::cast(other);
- return v8::internal::SameValue(x->get_lane(0), y->get_lane(0)) &&
- v8::internal::SameValue(x->get_lane(1), y->get_lane(1)) &&
- v8::internal::SameValue(x->get_lane(2), y->get_lane(2)) &&
- v8::internal::SameValue(x->get_lane(3), y->get_lane(3));
- }
return false;
}
@@ -725,14 +702,6 @@
}
if (IsString() && other->IsString()) {
return String::cast(this)->Equals(String::cast(other));
- }
- if (IsFloat32x4() && other->IsFloat32x4()) {
- Float32x4* x = Float32x4::cast(this);
- Float32x4* y = Float32x4::cast(other);
- return v8::internal::SameValueZero(x->get_lane(0), y->get_lane(0)) &&
- v8::internal::SameValueZero(x->get_lane(1), y->get_lane(1)) &&
- v8::internal::SameValueZero(x->get_lane(2), y->get_lane(2)) &&
- v8::internal::SameValueZero(x->get_lane(3), y->get_lane(3));
}
return false;
}
@@ -1546,12 +1515,8 @@
void Float32x4::Float32x4Print(std::ostream& os) { // NOLINT
- char arr[100];
- Vector<char> buffer(arr, arraysize(arr));
- os << std::string(DoubleToCString(get_lane(0), buffer)) << ", "
- << std::string(DoubleToCString(get_lane(1), buffer)) << ", "
- << std::string(DoubleToCString(get_lane(2), buffer)) << ", "
- << std::string(DoubleToCString(get_lane(3), buffer));
+ os << get_lane(0) << ", " << get_lane(1) << ", " << get_lane(2) << ", "
+ << get_lane(3);
}
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698