Support Component Actions in the toolbar.

chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

Index: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
diff --git a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
index 9a205eded0af0041ff9cc2c50c00f4958cba0811..f0652b16b330ad0585b46658edc5ee11cc4f3453 100644
--- a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
+++ b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
@@ -17,11 +17,18 @@ class ToolbarActionViewController;
 // components of chrome, such as ChromeCast.
 class ComponentToolbarActionsFactory {
  public:
+  // Component Action IDs.
+  static const char kMediaRouterActionId[];
+  static const char kMockActionId[]; // Only used for testing.

[mark a. foltz, 2015/08/04 21:57:21]

Nit: Two spaces between semicolon and comment.

Also I usually see naming like "kActionIdForTest[]", but stick with the style in
surrounding code if there is one.

[apacible, 2015/08/05 01:03:41]

Done. There is some *ForTest / *ForTesting usage in c/b/ui/toolbar, so I updated
this to be "kActionIdForTest[]".

+
   ComponentToolbarActionsFactory();
   ~ComponentToolbarActionsFactory();
 
   static ComponentToolbarActionsFactory* GetInstance();
 
+  // Returns a list of ids of the Chrome Actions.

[mark a. foltz, 2015/08/04 21:57:21]

Can you use the term "Component" instead of Chrome to be consistent with class
naming?

[apacible, 2015/08/05 01:03:41]

Done.

+  static std::vector<std::string> GetComponentIds();

[mark a. foltz, 2015/08/04 21:57:21]

Since we don't support move rvalues yet can we pass in a pointer to a
std::vector as a return value?  Otherwise you could be allocating the vector 2
or 3 times.

Regardless, follow the style for returned STL containers in this code base.

[apacible, 2015/08/05 01:03:41]

Done.

+
   // Returns a collection of controllers for Chrome Actions. Declared virtual
   // for testing.
   virtual ScopedVector<ToolbarActionViewController>