Support Component Actions in the toolbar.

chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_
 #define CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 
 class Browser;
 class Profile;
 class ToolbarActionViewController;
 
 // The registry for all component toolbar actions. Component toolbar actions
 // are actions that live in the toolbar (like extension actions), but are
 // components of chrome, such as ChromeCast.
 class ComponentToolbarActionsFactory {
  public:
+  // Component Action IDs.
+  static const char kMediaRouterActionId[];
+  static const char kMockActionId[]; // Only used for testing.

[mark a. foltz, 2015/08/04 21:57:21]

Nit: Two spaces between semicolon and comment.

Also I usually see naming like "kActionIdForTest[]", but stick with the style in
surrounding code if there is one.

[apacible, 2015/08/05 01:03:41]

Done. There is some *ForTest / *ForTesting usage in c/b/ui/toolbar, so I updated
this to be "kActionIdForTest[]".

+
   ComponentToolbarActionsFactory();
   ~ComponentToolbarActionsFactory();
 
   static ComponentToolbarActionsFactory* GetInstance();
 
+  // Returns a list of ids of the Chrome Actions.

[mark a. foltz, 2015/08/04 21:57:21]

Can you use the term "Component" instead of Chrome to be consistent with class
naming?

[apacible, 2015/08/05 01:03:41]

Done.

+  static std::vector<std::string> GetComponentIds();

[mark a. foltz, 2015/08/04 21:57:21]

Since we don't support move rvalues yet can we pass in a pointer to a
std::vector as a return value?  Otherwise you could be allocating the vector 2
or 3 times.

Regardless, follow the style for returned STL containers in this code base.

[apacible, 2015/08/05 01:03:41]

Done.

+
   // Returns a collection of controllers for Chrome Actions. Declared virtual
   // for testing.
   virtual ScopedVector<ToolbarActionViewController>
       GetComponentToolbarActions(Browser* browser);
 
   // Returns the number of component actions.
   int GetNumComponentActions(Browser* browser);
 
   // Sets the factory to use for testing purposes.
   // Ownership remains with the caller.
   static void SetTestingFactory(ComponentToolbarActionsFactory* factory);
 
  private:
   // The number of component actions. Initially set to -1 to denote that the
   // count has not been checked yet.
   int num_component_actions_;
 
   DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_