Chromium Code Reviews Chromium Code Reviews
Issue
1240963002:
Revert of Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning (Closed)
DescriptionRevert of Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning (patchset #6 id:120001 of https://codereview.chromium.org/1238753005/)
Reason for revert:
The new tests are hitting some ASSERT in debug on Android:
********************************************************************************
C 87.837s Main [CRASH] FontPlatformDataTest.AhemHasNoSpaceInLigaturesOrKerning:
C 87.837s Main ASSERTION FAILED: m_ptr
C 87.837s Main ../../third_party/WebKit/Source/wtf/OwnPtr.h(66) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = blink::FontCustomPlatformData; WTF::OwnPtr<T>::PtrType = blink::FontCustomPlatformData*; WTF::OwnPtr<T>::ValueType = blink::FontCustomPlatformData]
C 87.837s Main
C 87.837s Main [CRASH] FontPlatformDataTest.AhemSpaceLigatureHasNoSpaceWithoutFontFeatures:
C 87.837s Main ASSERTION FAILED: m_ptr
C 87.837s Main ../../third_party/WebKit/Source/wtf/OwnPtr.h(66) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = blink::FontCustomPlatformData; WTF::OwnPtr<T>::PtrType = blink::FontCustomPlatformData*; WTF::OwnPtr<T>::ValueType = blink::FontCustomPlatformData]
C 87.837s Main
C 87.837s Main [CRASH] FontPlatformDataTest.AhemSpaceLigatureHasSpaceInLigaturesOrKerning:
C 87.837s Main ASSERTION FAILED: m_ptr
C 87.838s Main ../../third_party/WebKit/Source/wtf/OwnPtr.h(66) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = blink::FontCustomPlatformData; WTF::OwnPtr<T>::PtrType = blink::FontCustomPlatformData*; WTF::OwnPtr<T>::ValueType = blink::FontCustomPlatformData]
C 87.838s Main ********************************************************************************
See the full output in
https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/27094/steps/webkit_unit_tests/logs/stdio
Original issue's description:
> Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning
>
> Add a set of unit tests for the hasSpaceInLigaturesOrKerning method that
> verifies that the correct value is returned for a font that has space in
> either the GPOS or GSUB tables vs for one that does not. Also tests that
> the check is bypassed and false is returned if kerning and ligatures are
> both disabled. Finally, it fixes the failure mode in that the method now
> returns false in cases where the font tables cannot be accessed.
>
> R=drott@chromium.org
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199059
TBR=leviw@chromium.org,drott@chromium.org,eae@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199072
Patch Set 1 #Patch Set 2 : Manual revert. #Patch Set 3 : Rebased again. #
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
