Preliminary support for Windows manifests in the GN build.

Preliminary support for Windows manifests in the GN build.

Adds manifest data for content shell. The result matches the GYP build.

Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome.

Moved the common control compat files that were duplicated to a shared place in build/win, update cloud_print and remoting which had their own copies to use this shared one.

BUG=510612
Committed: https://crrev.com/c34cad367a0557d8b029fb81d04cc37b5979fee0
Cr-Commit-Position: refs/heads/master@{#339663}

[brettw, 2015-07-17 19:26:13]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-07-17 19:26:14]

Dirk: review GN setup.

Everybody else: please look at GN Windows manifest setup and tell me if it looks
correct. GYP does a whole lot of stuff with automatically generated manifests
based on GYP variables and I think is only for backwards compat with GYP's MSVC
integration.

GYP also does a second-phase checking step to make sure the manifest generated
by the linker matches what the build specifies since apparently one can specify
pragmas in the source code to change the manifest. GN doesn't do any of this.
This manifest support is simple and clear, I don't know of anybody that actually
knows about the pragmas, and if you wrote a pragma it would be obvious you
screwed up because it would have no effect.

[Dirk Pranke, 2015-07-17 20:02:47]

lgtm

https://codereview.chromium.org/1240893004/diff/40001/build/config/win/manife...
File build/config/win/manifest.gni (right):

https://codereview.chromium.org/1240893004/diff/40001/build/config/win/manife...
build/config/win/manifest.gni:18: # HOW MANIFESTS WORK IN THE GN BUILD
can you move this comment above the variables?

https://codereview.chromium.org/1240893004/diff/40001/build/config/win/manife...
build/config/win/manifest.gni:20: # Use the windows_manifest declaration to
declare a manifest generation step.
s/declaration/template?

[brettw, 2015-07-17 21:28:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 21:29:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240893004/60001

[commit-bot: I haz the power, 2015-07-17 21:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 21:36:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-17 21:45:16]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 21:45:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240893004/20002

[commit-bot: I haz the power, 2015-07-17 21:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 21:54:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-20 18:16:26]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 18:17:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240893004/90001

[commit-bot: I haz the power, 2015-07-20 21:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 21:37:11]

Dry run: This issue passed the CQ dry run.

[gab, 2015-07-21 15:54:58]

gab@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2015-07-21 15:54:58]

lgtm, I really like the ability of merging various manifests ourselves rather
than depending on the VS tools to do it.

(didn't review build/config/win/manifest.gni lines 75 and up as I know nothing
about GNI syntax).

[brettw, 2015-07-21 16:08:05]

Thanks!

[brettw, 2015-07-21 16:08:09]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-21 16:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1240893004/#ps90001
(title: " ")

[commit-bot: I haz the power, 2015-07-21 16:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240893004/90001

[commit-bot: I haz the power, 2015-07-21 16:15:29]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-07-21 16:17:41]

Patchset 6 (id:??) landed as
https://crrev.com/c34cad367a0557d8b029fb81d04cc37b5979fee0
Cr-Commit-Position: refs/heads/master@{#339663}

[Nico, 2015-07-21 16:58:17]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-21 16:58:17]

This broke building remoting with gyp:

http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/1697/ste...

ninja:error: '../../remoting/host/win/common-controls.manifest', needed by
'remote_assistance_host.exe', missing and no known rule to make it


Reverting. (Rietveld's revert button doesn't work for this patch, so doing it
manually)

[Nico, 2015-07-21 17:00:38]

revert: https://codereview.chromium.org/1249723002/

[Denis Kuznetsov (DE-MUC), 2015-07-21 17:05:13]

Manually reverted as https://codereview.chromium.org/1246013003/
It broke build on Win64 builder dbg.