DescriptionReland of place system IO calls in chromecast/crash with Chrome utilities. (patchset #1 id:1 of https://codereview.chromium.org/1239083005/)
Reason for revert:
The offending test case shall be guarded with ENABLE_THREAD_RESTRICTIONS.
Original issue's description:
> Revert of Replace system IO calls in chromecast/crash with Chrome utilities. (patchset #9 id:160001 of https://codereview.chromium.org/1227963002/)
>
> Reason for revert:
> Breaks CastCrashReporterClientTest.EndToEndTestOnIORestrictedThread:
>
> https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/2709
>
> Original issue's description:
> > Replace system IO calls in chromecast/crash with Chrome utilities.
> >
> > System IO calls had been used to avoid thread IO restrictions in the
> > crash handler. This change replaces each of these calls with the more
> > platform-independent, stable Chrome IO utilities from ::base. Thread
> > restrictions are disabled in crash_util.cc.
> >
> > BUG= b/22329428
> >
> > Committed: https://crrev.com/4927df40d0342522fc268f884835b43f9004549e
> > Cr-Commit-Position: refs/heads/master@{#339161}
>
> TBR=wzhong@chromium.org,bcf@google.com,gunsch@chromium.org,gfhuang@chromium.org,slan@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= b/22329428
>
> Committed: https://crrev.com/4306386450441c312f0e94af12074ae1534b4117
> Cr-Commit-Position: refs/heads/master@{#339183}
BUG= b/22329428
Committed: https://crrev.com/5ad01a654b3aef2391dfe3b387af11a88e0d34b1
Cr-Commit-Position: refs/heads/master@{#339280}
Patch Set 1 #Patch Set 2 : Fix: Guard thread-restricted test with #define #
Messages
Total messages: 8 (1 generated)
|