Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1240843003: Reland of place system IO calls in chromecast/crash with Chrome utilities. (Closed)

Created:
5 years, 5 months ago by slan
Modified:
5 years, 5 months ago
CC:
chromium-reviews, kalyank, lcwu+watch_chromium.org, sadrul, gunsch+watch_chromium.org, gfhuang
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of place system IO calls in chromecast/crash with Chrome utilities. (patchset #1 id:1 of https://codereview.chromium.org/1239083005/) Reason for revert: The offending test case shall be guarded with ENABLE_THREAD_RESTRICTIONS. Original issue's description: > Revert of Replace system IO calls in chromecast/crash with Chrome utilities. (patchset #9 id:160001 of https://codereview.chromium.org/1227963002/) > > Reason for revert: > Breaks CastCrashReporterClientTest.EndToEndTestOnIORestrictedThread: > > https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/2709 > > Original issue's description: > > Replace system IO calls in chromecast/crash with Chrome utilities. > > > > System IO calls had been used to avoid thread IO restrictions in the > > crash handler. This change replaces each of these calls with the more > > platform-independent, stable Chrome IO utilities from ::base. Thread > > restrictions are disabled in crash_util.cc. > > > > BUG= b/22329428 > > > > Committed: https://crrev.com/4927df40d0342522fc268f884835b43f9004549e > > Cr-Commit-Position: refs/heads/master@{#339161} > > TBR=wzhong@chromium.org,bcf@google.com,gunsch@chromium.org,gfhuang@chromium.org,slan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= b/22329428 > > Committed: https://crrev.com/4306386450441c312f0e94af12074ae1534b4117 > Cr-Commit-Position: refs/heads/master@{#339183} BUG= b/22329428 Committed: https://crrev.com/5ad01a654b3aef2391dfe3b387af11a88e0d34b1 Cr-Commit-Position: refs/heads/master@{#339280}

Patch Set 1 #

Patch Set 2 : Fix: Guard thread-restricted test with #define #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -245 lines) Patch
M chromecast/app/linux/cast_crash_reporter_client_unittest.cc View 1 2 chunks +104 lines, -59 lines 0 comments Download
M chromecast/crash/linux/crash_util.cc View 1 4 chunks +13 lines, -8 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator.h View 1 1 chunk +3 lines, -13 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator.cc View 1 1 chunk +7 lines, -73 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator_unittest.cc View 1 3 chunks +5 lines, -85 lines 0 comments Download
M chromecast/crash/linux/minidump_generator.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
slan
Created Reland of place system IO calls in chromecast/crash with Chrome utilities.
5 years, 5 months ago (2015-07-17 16:37:37 UTC) #1
slan
This patch is verified locally and ready for review. The IO-restricted thread test is only ...
5 years, 5 months ago (2015-07-17 17:15:45 UTC) #2
slan
On 2015/07/17 17:15:45, slan wrote: > This patch is verified locally and ready for review. ...
5 years, 5 months ago (2015-07-17 17:20:22 UTC) #3
gunsch
lgtm
5 years, 5 months ago (2015-07-17 17:24:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240843003/170001
5 years, 5 months ago (2015-07-17 17:26:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:170001)
5 years, 5 months ago (2015-07-17 17:51:53 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 17:52:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ad01a654b3aef2391dfe3b387af11a88e0d34b1
Cr-Commit-Position: refs/heads/master@{#339280}

Powered by Google App Engine
This is Rietveld 408576698