Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chromecast/crash/linux/minidump_generator.h

Issue 1240843003: Reland of place system IO calls in chromecast/crash with Chrome utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix: Guard thread-restricted test with #define Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_ 5 #ifndef CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_
6 #define CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_ 6 #define CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 namespace chromecast { 10 namespace chromecast {
11 11
12 // An interface to generate a minidump at a given filepath.
12 class MinidumpGenerator { 13 class MinidumpGenerator {
13 public: 14 public:
14 virtual ~MinidumpGenerator() {} 15 virtual ~MinidumpGenerator() {}
15 16
16 // Interface to generate a minidump file in given path. 17 // Generates a minidump file at |minidump_path|. This method should only be
17 // This is called inside MinidumpWriter::DoWorkLocked(). 18 // called on a thread without IO restrictions, as non-trivial implementations
19 // will almost certainly require IO permissions. Returns true if minidump was
20 // successfully generated.
18 virtual bool Generate(const std::string& minidump_path) = 0; 21 virtual bool Generate(const std::string& minidump_path) = 0;
19 }; 22 };
20 23
21 } // namespace chromecast 24 } // namespace chromecast
22 25
23 #endif // CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_ 26 #endif // CHROMECAST_CRASH_LINUX_MINIDUMP_GENERATOR_H_
OLDNEW
« no previous file with comments | « chromecast/crash/linux/dummy_minidump_generator_unittest.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698