Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 12408009: Merge 144236 (Closed)

Created:
7 years, 10 months ago by jamesr
Modified:
7 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 144236 > Plugin in iframe may not display > https://bugs.webkit.org/show_bug.cgi?id=109879 > > Patch by John Bauman <jbauman@chromium.org>; on 2013-02-27 > Reviewed by Simon Fraser. > > Source/WebCore: > > Changing the cliprect on a layer containing an iframe may change the > cliprect of plugins inside the iframe, so recursively tell all plugins > in iframes that their cliprect has changed after doing layout on the > outer frame. > > Test: plugins/plugin-clip-subframe.html > > * platform/ScrollView.cpp: > (WebCore::ScrollView::clipRectChanged): > * platform/ScrollView.h: > * platform/Widget.h: > (WebCore::Widget::clipRectChanged): > * plugins/PluginView.cpp: > (WebCore::PluginView::clipRectChanged): > * plugins/PluginView.h: > * rendering/RenderWidget.cpp: > (WebCore::RenderWidget::setWidgetGeometry): > > Source/WebKit/chromium: > > Use clipRectChanged to update the geometry. > > * src/WebPluginContainerImpl.cpp: > (WebKit::WebPluginContainerImpl::clipRectChanged): > * src/WebPluginContainerImpl.h: > > Source/WebKit/mac: > > Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly. > > * Plugins/WebBaseNetscapePluginView.h: > * WebCoreSupport/WebFrameLoaderClient.mm: > (NetscapePluginWidget::clipRectChanged): > > Source/WebKit2: > > Update geometry when cliprect changes. > > * WebProcess/Plugins/PluginView.cpp: > (WebKit::PluginView::clipRectChanged): > * WebProcess/Plugins/PluginView.h: > > Tools: > > LogNPPSetWindow will be used with other ports as well. > > * DumpRenderTree/DumpRenderTree.gypi: > * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: > > LayoutTests: > > Use log-npp-set-window to ensure plugin clip changes correctly. > > * platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added. > * platform/mac/plugins/plugin-clip-subframe-expected.txt: Added. > * plugins/plugin-clip-subframe-expected.txt: Added. > * plugins/plugin-clip-subframe.html: Added. > * plugins/resources/plugin-clip-subframe-iframe.html: Added. TBR=jbauman@chromium.org BUG=168900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18664 lines, -1 line) Patch
M LayoutTests/ChangeLog View 2 chunks +10254 lines, -6 lines 0 comments Download
A + LayoutTests/platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/plugins/plugin-clip-subframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/plugins/plugin-clip-subframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/plugins/plugin-clip-subframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/plugins/resources/plugin-clip-subframe-iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/ScrollView.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/ScrollView.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebCore/platform/Widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/plugins/PluginView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/plugins/PluginView.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderWidget.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +1118 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebPluginContainerImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/mac/ChangeLog View 1 chunk +308 lines, -0 lines 0 comments Download
M Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebKit2/ChangeLog View 1 chunk +3639 lines, -0 lines 0 comments Download
M Source/WebKit2/WebProcess/Plugins/PluginView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit2/WebProcess/Plugins/PluginView.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Tools/ChangeLog View 1 chunk +3307 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/DumpRenderTree.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
7 years, 10 months ago (2013-03-11 19:58:55 UTC) #1
jamesr
7 years, 10 months ago (2013-03-11 19:59:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145392.

Powered by Google App Engine
This is Rietveld 408576698