OLD | NEW |
| 1 2013-02-27 John Bauman <jbauman@chromium.org> |
| 2 |
| 3 Plugin in iframe may not display |
| 4 https://bugs.webkit.org/show_bug.cgi?id=109879 |
| 5 |
| 6 Reviewed by Simon Fraser. |
| 7 |
| 8 Use clipRectChanged to update the geometry. |
| 9 |
| 10 * src/WebPluginContainerImpl.cpp: |
| 11 (WebKit::WebPluginContainerImpl::clipRectChanged): |
| 12 * src/WebPluginContainerImpl.h: |
| 13 |
| 14 2013-02-27 Stephen Chenney <schenney@chromium.org> |
| 15 |
| 16 RenderTableCellDeathTest unit test fails on mac |
| 17 https://bugs.webkit.org/show_bug.cgi?id=110992 |
| 18 |
| 19 Unreviewed second attempt. Trying to get the right define for the OS. |
| 20 |
| 21 * tests/RenderTableCellTest.cpp: |
| 22 |
| 23 2013-02-27 Stephen Chenney <schenney@chromium.org> |
| 24 |
| 25 RenderTableCellDeathTest unit test fails on mac |
| 26 https://bugs.webkit.org/show_bug.cgi?id=110992 |
| 27 |
| 28 Unreviewed disabling of test that is hanging or crashing on Mac. |
| 29 |
| 30 * tests/RenderTableCellTest.cpp: |
| 31 |
| 32 2013-02-27 James Robinson <jamesr@chromium.org> |
| 33 |
| 34 [chromium] Remove suppression invalidation logic from WebViewImpl |
| 35 https://bugs.webkit.org/show_bug.cgi?id=110999 |
| 36 |
| 37 Reviewed by Adrienne Walker. |
| 38 |
| 39 This suppression logic is now handled on the embedder side. In fact, sch
eduleComposite() is now only used |
| 40 by DumpRenderTree. |
| 41 |
| 42 * src/WebViewImpl.cpp: |
| 43 (WebKit::WebViewImpl::WebViewImpl): |
| 44 (WebKit::WebViewImpl::suppressInvalidations): |
| 45 (WebKit::WebViewImpl::scheduleComposite): |
| 46 * src/WebViewImpl.h: |
| 47 |
| 48 2013-02-27 Glenn Adams <glenn@skynav.com> |
| 49 |
| 50 Add ENABLE_CSS3_TEXT_LINE_BREAK flag. |
| 51 https://bugs.webkit.org/show_bug.cgi?id=110944 |
| 52 |
| 53 Reviewed by Dean Jackson. |
| 54 |
| 55 * features.gypi: |
| 56 |
| 57 2013-02-26 James Robinson <jamesr@chromium.org> |
| 58 |
| 59 [chromium] Remove WebViewImpl::animate shimmy out through compositor |
| 60 https://bugs.webkit.org/show_bug.cgi?id=110935 |
| 61 |
| 62 Reviewed by Adrienne Walker. |
| 63 |
| 64 WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusing
ly similar. ::animate() implements |
| 65 the WebWidget API and is called by content::RenderWidget and WebViewHost
. ::updateAnimations() implements |
| 66 the WebLayerTreeViewClient API and is called by content::RenderWidgetCom
positor and by ::animate(). The |
| 67 important part of this indirection is that whenever the compositor is ac
tive, all animation calls must |
| 68 route through cc::LayerTreeHost before entering into WebCore's animation
code so that the compositor |
| 69 can set the appropriate rate limiting state. Animations may originate fr
om |
| 70 content::RenderWidget::AnimateIfNeeded when in software and single threa
ded mode or from |
| 71 cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the
long ago, content::RenderWidget had no |
| 72 idea if compositing was active or not and always called WebWidget::anima
te(), so WebViewImpl::animate() had to |
| 73 redirect to the compositor when appropriate. |
| 74 |
| 75 Now (as of chromium r180947) RenderWidget calls WebWidget::animate only
when in software mode and otherwise |
| 76 calls directly into the compositor. Thus WebViewImpl::animate() no longe
r needs to do this check. In a |
| 77 follow-up, WebViewImpl::updateAnimations will go away completely in favo
r of just calling WebWidget::animate in |
| 78 all cases. |
| 79 |
| 80 * src/WebViewImpl.cpp: |
| 81 (WebKit::WebViewImpl::animate): |
| 82 (WebKit::WebViewImpl::updateAnimations): |
| 83 |
| 84 2013-02-27 Sheriff Bot <webkit.review.bot@gmail.com> |
| 85 |
| 86 Unreviewed, rolling out r144179. |
| 87 http://trac.webkit.org/changeset/144179 |
| 88 https://bugs.webkit.org/show_bug.cgi?id=110980 |
| 89 |
| 90 Breaks compilation (Requested by vsevik on #webkit). |
| 91 |
| 92 * public/WebTextInputType.h: |
| 93 * src/WebViewImpl.cpp: |
| 94 (WebKit::WebViewImpl::textInputInfo): |
| 95 (WebKit::WebViewImpl::textInputType): |
| 96 |
| 97 2013-02-27 Stephen Chenney <schenney@chromium.org> |
| 98 |
| 99 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Andro
id |
| 100 https://bugs.webkit.org/show_bug.cgi?id=110922 |
| 101 |
| 102 Unreviewed build fix. |
| 103 |
| 104 * tests/GIFImageDecoderTest.cpp: |
| 105 (WebKit): |
| 106 (WebKit::TEST): Disable the entire test on Android. |
| 107 |
| 108 2013-02-27 Seigo Nonaka <nona@chromium.org> |
| 109 |
| 110 [Chromium] Should not return WebTextInputTypeNone for date input element
. |
| 111 https://bugs.webkit.org/show_bug.cgi?id=110740 |
| 112 |
| 113 Reviewed by Kent Tamura. |
| 114 |
| 115 In the case of Windows 8, text input state including on-screen keyboard
is controlled by the |
| 116 value of WebTextInputType returned from WebViewImpl::textInputType(). |
| 117 In past, it returned WebTextInputTypeDate for date text input but now it
returns |
| 118 WebTextInputTypeNone. |
| 119 WebTextInputTypeNone is used for non editable node, so on-screen keyboar
d will be hidden if |
| 120 the date text input is focused. So there is no way to input on Windows
8 tablet without |
| 121 physical keyboard except tapping small up/down arrow. |
| 122 |
| 123 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField. |
| 124 * src/WebViewImpl.cpp: |
| 125 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of edi
table or not. It is |
| 126 safe because textInputType returns editable type only for known editable
element. |
| 127 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeFi
eld for the date |
| 128 time field element. |
| 129 |
| 130 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 131 |
| 132 Unreviewed, rolling out r144129. |
| 133 http://trac.webkit.org/changeset/144129 |
| 134 https://bugs.webkit.org/show_bug.cgi?id=110947 |
| 135 |
| 136 Breaks compilation on chromium mac and win (Requested by |
| 137 vsevik on #webkit). |
| 138 |
| 139 * src/WebViewImpl.cpp: |
| 140 (WebKit::WebViewImpl::willBeginFrame): |
| 141 (WebKit): |
| 142 (WebKit::WebViewImpl::didBeginFrame): |
| 143 * src/WebViewImpl.h: |
| 144 * tests/WebLayerTreeViewTestCommon.h: |
| 145 |
| 146 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 147 |
| 148 Unreviewed. Rolled Chromium DEPS to r184829. Requested by |
| 149 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot. |
| 150 |
| 151 * DEPS: |
| 152 |
| 153 2013-02-26 James Robinson <jamesr@chromium.org> |
| 154 |
| 155 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame |
| 156 https://bugs.webkit.org/show_bug.cgi?id=110928 |
| 157 |
| 158 Reviewed by Adrienne Walker. |
| 159 |
| 160 * src/WebViewImpl.cpp: |
| 161 * src/WebViewImpl.h: |
| 162 * tests/WebLayerTreeViewTestCommon.h: |
| 163 |
| 164 2013-02-26 Alpha Lam <hclam@chromium.org> |
| 165 |
| 166 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Andro
id |
| 167 https://bugs.webkit.org/show_bug.cgi?id=110922 |
| 168 |
| 169 Unreviewed. Build fix. |
| 170 |
| 171 * tests/GIFImageDecoderTest.cpp: |
| 172 (WebKit): |
| 173 |
| 174 2013-02-26 James Robinson <jamesr@chromium.org> |
| 175 |
| 176 [chromium] Remove unused WebLayerTreeViewClient calls |
| 177 https://bugs.webkit.org/show_bug.cgi?id=110923 |
| 178 |
| 179 Reviewed by Adrienne Walker. |
| 180 |
| 181 These notifications existed for instrumentation, but now the instrumenta
tion routes |
| 182 through WebDevToolsAgent. |
| 183 |
| 184 * src/WebViewImpl.cpp: |
| 185 * src/WebViewImpl.h: |
| 186 * tests/WebLayerTreeViewTestCommon.h: |
| 187 |
| 188 2013-02-26 Dirk Pranke <dpranke@chromium.org> |
| 189 |
| 190 Roll Chromium DEPS from r183905 -> r184646. |
| 191 |
| 192 Unreviewed. |
| 193 |
| 194 * DEPS: |
| 195 |
| 196 2013-02-26 James Robinson <jamesr@chromium.org> |
| 197 |
| 198 [chromium] Remove unused WebWidget::instrument calls |
| 199 https://bugs.webkit.org/show_bug.cgi?id=110906 |
| 200 |
| 201 Reviewed by Jochen Eisinger. |
| 202 |
| 203 These calls are now routed through WebDevToolsAgent. |
| 204 |
| 205 * public/WebWidget.h: |
| 206 * src/WebViewImpl.cpp: |
| 207 (WebKit::WebViewImpl::willBeginFrame): |
| 208 * src/WebViewImpl.h: |
| 209 |
| 210 2013-02-20 Alpha Lam <hclam@chromium.org> |
| 211 |
| 212 GIFImageReader to read from source data directly |
| 213 https://bugs.webkit.org/show_bug.cgi?id=109662 |
| 214 |
| 215 Reviewed by Stephen White. |
| 216 |
| 217 Added the following unit tests to test new logic in GIFImageDecoder: |
| 218 |
| 219 GIFImageDecoderTest.decodeTwoFrames |
| 220 Test that it can decode a multi-frame GIF image correctly. |
| 221 |
| 222 GIFImageDecoderTest.parseAndDecode |
| 223 First perform a parse operation and then a decode operation. Expect |
| 224 that parse and decode operates correctly. |
| 225 |
| 226 GIFImageDecoderTest.parseByteByByte |
| 227 Test that multi-frame GIF image can be parsed correctly byte by byte. |
| 228 |
| 229 GIFImageDecoderTest.parseAndDecodeByteByByte |
| 230 Run a loop to feed decoder byte by byte, perform a parse and then |
| 231 decode operation and make sure frames are decoded correctly. |
| 232 |
| 233 GIFImageDecoderTest.brokenSecondFrame |
| 234 Decode a GIF image with second frame broken. Expect that the first |
| 235 frame can be decoded correctly. |
| 236 |
| 237 * WebKit.gypi: |
| 238 * tests/GIFImageDecoderTest.cpp: Added. |
| 239 (WebKit): |
| 240 (WebKit::readFile): |
| 241 (WebKit::TEST): |
| 242 * tests/data/broken.gif: Added. |
| 243 |
| 244 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 245 |
| 246 Unreviewed, rolling out r144065. |
| 247 http://trac.webkit.org/changeset/144065 |
| 248 https://bugs.webkit.org/show_bug.cgi?id=110896 |
| 249 |
| 250 Causing failures and crashes on Chromium Win7 and Win XP |
| 251 (Requested by schenney on #webkit). |
| 252 |
| 253 * features.gypi: |
| 254 |
| 255 2013-02-26 Levi Weintraub <leviw@chromium.org> |
| 256 |
| 257 Add support for 8 bit TextRuns for Chromium/HarfBuzz |
| 258 https://bugs.webkit.org/show_bug.cgi?id=99393 |
| 259 |
| 260 Reviewed by Eric Seidel. |
| 261 |
| 262 Enabling 8 bit text runs for Chromium. |
| 263 |
| 264 * features.gypi: |
| 265 |
| 266 2013-02-26 Dmitry Zvorygin <zvorygin@chromium.org> |
| 267 |
| 268 Merged Tip and Debug log levels for web console. |
| 269 https://bugs.webkit.org/show_bug.cgi?id=109919 |
| 270 |
| 271 Reviewed by Pavel Feldman. |
| 272 |
| 273 In every component either TIP or DEBUG level was used for reporting, |
| 274 but not both. This patch is prerequisite for Web Inspector console log f
iltering. |
| 275 |
| 276 * public/WebConsoleMessage.h: |
| 277 * src/AssertMatchingEnums.cpp: |
| 278 * src/WebFrameImpl.cpp: |
| 279 (WebKit::WebFrameImpl::addMessageToConsole): |
| 280 |
| 281 2013-02-26 Andrey Kosyakov <caseq@chromium.org> |
| 282 |
| 283 Plumbing trace events to Timeline |
| 284 |
| 285 Web Inspector: plumb trace events to Timeline agent |
| 286 https://bugs.webkit.org/show_bug.cgi?id=105796 |
| 287 |
| 288 Reviewed by Pavel Feldman. |
| 289 |
| 290 * public/WebDevToolsAgentClient.h: |
| 291 (WebDevToolsAgentClient): |
| 292 (WebKit::WebDevToolsAgentClient::setTraceEventCallback): |
| 293 * src/InspectorClientImpl.cpp: |
| 294 (WebKit::InspectorClientImpl::setTraceEventCallback): |
| 295 (WebKit): |
| 296 * src/InspectorClientImpl.h: |
| 297 (InspectorClientImpl): |
| 298 * src/WebDevToolsAgentImpl.cpp: |
| 299 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback): |
| 300 (WebKit): |
| 301 * src/WebDevToolsAgentImpl.h: |
| 302 (WebDevToolsAgentImpl): |
| 303 |
| 304 2013-02-01 Andrey Kosyakov <caseq@chromium.org> |
| 305 |
| 306 Web Inspector: plumb trace events to Timeline agent |
| 307 https://bugs.webkit.org/show_bug.cgi?id=105796 |
| 308 |
| 309 Reviewed by Pavel Feldman. |
| 310 |
| 311 Plumb trace events to Inspector. |
| 312 |
| 313 * public/WebDevToolsAgentClient.h: |
| 314 (WebDevToolsAgentClient): |
| 315 (WebKit::WebDevToolsAgentClient::setTraceEventCallback): |
| 316 * src/InspectorClientImpl.cpp: |
| 317 (WebKit::InspectorClientImpl::setTraceEventCallback): |
| 318 (WebKit): |
| 319 * src/InspectorClientImpl.h: |
| 320 (InspectorClientImpl): |
| 321 * src/WebDevToolsAgentImpl.cpp: |
| 322 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback): |
| 323 (WebKit): |
| 324 * src/WebDevToolsAgentImpl.h: |
| 325 (WebDevToolsAgentImpl): |
| 326 |
| 327 2013-02-26 Andrey Kosyakov <caseq@chromium.org> |
| 328 |
| 329 Unreviewed, rolling out r144041, r144044, and r144048. |
| 330 http://trac.webkit.org/changeset/144041 |
| 331 http://trac.webkit.org/changeset/144044 |
| 332 http://trac.webkit.org/changeset/144048 |
| 333 https://bugs.webkit.org/show_bug.cgi?id=105796 |
| 334 |
| 335 Broke build |
| 336 |
| 337 * public/WebDevToolsAgentClient.h: |
| 338 * src/InspectorClientImpl.cpp: |
| 339 * src/InspectorClientImpl.h: |
| 340 (InspectorClientImpl): |
| 341 * src/WebDevToolsAgentImpl.cpp: |
| 342 * src/WebDevToolsAgentImpl.h: |
| 343 (WebDevToolsAgentImpl): |
| 344 |
| 345 2013-02-01 Andrey Kosyakov <caseq@chromium.org> |
| 346 |
| 347 Web Inspector: plumb trace events to Timeline agent |
| 348 https://bugs.webkit.org/show_bug.cgi?id=105796 |
| 349 |
| 350 Reviewed by Pavel Feldman. |
| 351 |
| 352 Plumb trace events to Inspector. |
| 353 |
| 354 * public/WebDevToolsAgentClient.h: |
| 355 (WebDevToolsAgentClient): |
| 356 (WebKit::WebDevToolsAgentClient::setTraceEventCallback): |
| 357 * src/InspectorClientImpl.cpp: |
| 358 (WebKit::InspectorClientImpl::setTraceEventCallback): |
| 359 (WebKit): |
| 360 * src/InspectorClientImpl.h: |
| 361 (InspectorClientImpl): |
| 362 * src/WebDevToolsAgentImpl.cpp: |
| 363 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback): |
| 364 (WebKit): |
| 365 * src/WebDevToolsAgentImpl.h: |
| 366 (WebDevToolsAgentImpl): |
| 367 |
| 368 2013-02-26 Tien-Ren Chen <trchen@chromium.org> |
| 369 |
| 370 Implement coordinated scrollbar for subframes and overflow:scroll |
| 371 https://bugs.webkit.org/show_bug.cgi?id=109560 |
| 372 |
| 373 Reviewed by James Robinson. |
| 374 |
| 375 Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify |
| 376 impl-side scrolling and impl-side scrollbars for frames. |
| 377 |
| 378 Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify |
| 379 impl-side scrollbars. |
| 380 |
| 381 * tests/ScrollingCoordinatorChromiumTest.cpp: |
| 382 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumT
est): |
| 383 (WebKit::TEST_F): |
| 384 (WebKit): |
| 385 * tests/data/iframe-scrolling-inner.html: Added. |
| 386 * tests/data/iframe-scrolling.html: Added. |
| 387 |
| 388 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com> |
| 389 |
| 390 Unreviewed, rolling out r144016. |
| 391 http://trac.webkit.org/changeset/144016 |
| 392 https://bugs.webkit.org/show_bug.cgi?id=110856 |
| 393 |
| 394 Breaks compilation on chromium mac (Requested by vsevik on |
| 395 #webkit). |
| 396 |
| 397 * WebKit.gypi: |
| 398 * tests/KeyCodeConversionTest.cpp: Removed. |
| 399 |
| 400 2013-02-26 James Robinson <jamesr@chromium.org> |
| 401 |
| 402 [chromium] Fix continuous painting mode |
| 403 https://bugs.webkit.org/show_bug.cgi?id=110788 |
| 404 |
| 405 Reviewed by Adrienne Walker. |
| 406 |
| 407 Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no
longer be called, which |
| 408 broke continuous painting. Since continuous painting mode is meant to s
imply invalidate layers |
| 409 on each frame, it's a better fit for the animation system. This moves th
e invalidation calls |
| 410 into WebViewImpl::updateAnimations along with other animation type thing
s. |
| 411 |
| 412 Tested manually by enabling continuous painting mode in the inspector. T
here aren't any automated |
| 413 tests in WebKit for this feature. |
| 414 |
| 415 * src/WebViewImpl.cpp: |
| 416 (WebKit::WebViewImpl::setContinuousPaintingEnabled): |
| 417 (WebKit::WebViewImpl::didBeginFrame): |
| 418 (WebKit::WebViewImpl::updateAnimations): |
| 419 * src/painting/ContinuousPainter.cpp: |
| 420 (WebKit::ContinuousPainter::setNeedsDisplayRecursive): |
| 421 |
| 422 2013-02-26 James Weatherall <wez@chromium.org> |
| 423 |
| 424 keydown and keyup events have zero keycode for some numeric pad keys und
er Chromium on Linux |
| 425 https://bugs.webkit.org/show_bug.cgi?id=85642 |
| 426 |
| 427 Add tests to verify that the fixed keys generate the same keyCode values |
| 428 as their equivalents. |
| 429 |
| 430 Reviewed by Ojan Vafai. |
| 431 |
| 432 * WebKit.gypi: |
| 433 * tests/KeyCodeConversionTest.cpp: Added. |
| 434 (WebCore): |
| 435 (WebCore::TEST): |
| 436 |
| 437 2013-02-25 Rouslan Solomakhin <rouslan@chromium.org> |
| 438 |
| 439 Add expandedToParagraph() method to WebRange |
| 440 https://bugs.webkit.org/show_bug.cgi?id=110618 |
| 441 |
| 442 Reviewed by Adam Barth. |
| 443 |
| 444 Add a method expandedToParagraph() to WebRange to return a copy of the |
| 445 range expanded to paragraph boundaries. This method is to be used to |
| 446 query the spelling context around the misspelled word under cursor. |
| 447 |
| 448 * public/WebRange.h: |
| 449 (WebRange): Added expandedToParagraph() method declaration. |
| 450 * src/WebRange.cpp: |
| 451 (WebKit::WebRange::expandedToParagraph): Added method to copy range, exp
and the copied range to paragraph boundaries, and return the resulting range. |
| 452 (WebKit): Added expandedToParagraph() method definition. |
| 453 |
| 454 2013-02-25 James Robinson <jamesr@chromium.org> |
| 455 |
| 456 [chromium] WebViewImpl::m_client can be null in some unit tests, check i
t before calling |
| 457 https://bugs.webkit.org/show_bug.cgi?id=110834 |
| 458 |
| 459 Reviewed by Adrienne Walker. |
| 460 |
| 461 * src/WebViewImpl.cpp: |
| 462 (WebKit::WebViewImpl::suppressInvalidations): |
| 463 (WebKit::WebViewImpl::setRootGraphicsLayer): |
| 464 |
| 465 2013-02-25 Ken Kania <kkania@chromium.org> |
| 466 |
| 467 Remove browser patching mechanism for handling javascript dialogs in chr
omium port |
| 468 https://bugs.webkit.org/show_bug.cgi?id=110531 |
| 469 |
| 470 Reviewed by Pavel Feldman. |
| 471 |
| 472 * public/WebDevToolsAgent.h: |
| 473 * src/WebDevToolsAgentImpl.cpp: |
| 474 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog): |
| 475 (WebKit::browserHintToString): |
| 476 (WebKit::browserHintFromString): |
| 477 (WebKit::WebDevToolsAgent::patchWithBrowserData): |
| 478 |
| 479 2013-02-25 James Robinson <jamesr@chromium.org> |
| 480 |
| 481 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to
WebWidgetClient |
| 482 https://bugs.webkit.org/show_bug.cgi?id=110640 |
| 483 |
| 484 Reviewed by Adrienne Walker. |
| 485 |
| 486 This plumbs the WebViewImpl::m_suppressInvalidations logic out to the We
bWidgetClient so |
| 487 it can be implemented by the embedder. The existing logic is left in pla
ce for now, |
| 488 once the embedder side has landed WebViewImpl will be purely a pass-thro
ugh. |
| 489 |
| 490 * public/WebWidgetClient.h: |
| 491 (WebWidgetClient): |
| 492 (WebKit::WebWidgetClient::suppressCompositorScheduling): |
| 493 * src/WebViewImpl.cpp: |
| 494 (WebKit::WebViewImpl::suppressInvalidations): |
| 495 (WebKit::WebViewImpl::setRootGraphicsLayer): |
| 496 |
| 497 2013-02-25 Sheriff Bot <webkit.review.bot@gmail.com> |
| 498 |
| 499 Unreviewed, rolling out r143936. |
| 500 http://trac.webkit.org/changeset/143936 |
| 501 https://bugs.webkit.org/show_bug.cgi?id=110789 |
| 502 |
| 503 Causes webkit_unit_tests failures on android dbg (Requested by |
| 504 vollick on #webkit). |
| 505 |
| 506 * WebKit.gyp: |
| 507 * WebKit.gypi: |
| 508 * tests/GIFImageDecoderTest.cpp: Removed. |
| 509 * tests/data/broken.gif: Removed. |
| 510 |
| 511 2013-02-25 Alpha Lam <hclam@chromium.org> |
| 512 |
| 513 GIFImageReader to read from source data directly |
| 514 https://bugs.webkit.org/show_bug.cgi?id=109662 |
| 515 |
| 516 Reviewed by Stephen White. |
| 517 |
| 518 Added the following unit tests to test new logic in GIFImageDecoder: |
| 519 |
| 520 GIFImageDecoderTest.decodeTwoFrames |
| 521 Test that it can decode a multi-frame GIF image correctly. |
| 522 |
| 523 GIFImageDecoderTest.parseAndDecode |
| 524 First perform a parse operation and then a decode operation. Expect |
| 525 that parse and decode operates correctly. |
| 526 |
| 527 GIFImageDecoderTest.parseByteByByte |
| 528 Test that multi-frame GIF image can be parsed correctly byte by byte. |
| 529 |
| 530 GIFImageDecoderTest.parseAndDecodeByteByByte |
| 531 Run a loop to feed decoder byte by byte, perform a parse and then |
| 532 decode operation and make sure frames are decoded correctly. |
| 533 |
| 534 GIFImageDecoderTest.brokenSecondFrame |
| 535 Decode a GIF image with second frame broken. Expect that the first |
| 536 frame can be decoded correctly. |
| 537 |
| 538 * WebKit.gyp: |
| 539 * WebKit.gypi: |
| 540 * tests/GIFImageDecoderTest.cpp: Added. |
| 541 (WebKit): |
| 542 (WebKit::readFile): |
| 543 (WebKit::TEST): |
| 544 * tests/data/broken.gif: Added. |
| 545 |
| 546 2013-02-25 Andrey Kosyakov <caseq@chromium.org> |
| 547 |
| 548 Unreviewed follow-up to r143725, reduce chances test flakes on a slow bo
x. |
| 549 |
| 550 * src/js/Tests.js: |
| 551 (.TestSuite.prototype.testPageOverlayUpdate.step2): |
| 552 |
| 553 2013-02-25 Anton Vayvod <avayvod@chromium.org> |
| 554 |
| 555 [Chromium] Disable registerProtocolHandler on Android |
| 556 https://bugs.webkit.org/show_bug.cgi?id=110481 |
| 557 |
| 558 Reviewed by Julien Chaffraix. |
| 559 |
| 560 Chromium for Android has been exposing registerProtocolHandler, but the
feature wasn't |
| 561 actually wired up internally. Disable the feature to avoid breaking feat
ure detection until |
| 562 we can implement it properly. Previous attempt is at http://trac.webkit.
org/changeset/133465 |
| 563 See the discussion of the future implementation at http://crbug.com/1563
86 |
| 564 |
| 565 * features.gypi: Disable the flag for Android, enable it only for non-An
droid platforms. |
| 566 |
| 567 * src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to
break Android. |
| 568 |
| 569 2013-02-24 Hajime Morrita <morrita@google.com> |
| 570 |
| 571 [Custom Elements] Implement bare-bone document.register() |
| 572 https://bugs.webkit.org/show_bug.cgi?id=100229 |
| 573 |
| 574 Reviewed by Adam Barth. |
| 575 |
| 576 Added enableCustomDOMElements flag. |
| 577 |
| 578 * features.gypi: |
| 579 * public/WebRuntimeFeatures.h: |
| 580 (WebRuntimeFeatures): |
| 581 * src/WebRuntimeFeatures.cpp: |
| 582 (WebKit::WebRuntimeFeatures::enableCustomDOMElements): |
| 583 (WebKit): |
| 584 (WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled): |
| 585 |
| 586 2013-02-23 Mark Pilgrim <pilgrim@chromium.org> |
| 587 |
| 588 [Chromium] WebKit::initialize should take a Platform* now that WebKitPla
tformSupport is empty |
| 589 https://bugs.webkit.org/show_bug.cgi?id=110605 |
| 590 |
| 591 Reviewed by Adam Barth. |
| 592 |
| 593 Part of a larger refactoring series; see tracking bug 82948. |
| 594 |
| 595 * public/WebKit.h: |
| 596 (WebKit): |
| 597 * src/WebKit.cpp: |
| 598 (WebKit::initialize): |
| 599 (WebKit::initializeWithoutV8): |
| 600 (WebKit::webKitPlatformSupport): |
| 601 |
| 602 2013-02-22 David Dorwin <ddorwin@chromium.org> |
| 603 |
| 604 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is
never attached |
| 605 https://bugs.webkit.org/show_bug.cgi?id=110668 |
| 606 |
| 607 Reviewed by Adam Barth. |
| 608 |
| 609 This fixes http://crbug.com/172764 |
| 610 |
| 611 * src/WebHelperPluginImpl.cpp: |
| 612 (WebKit::WebHelperPluginImpl::destoryPage): |
| 613 |
| 614 2013-02-22 Aaron Colwell <acolwell@chromium.org> |
| 615 |
| 616 Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and i
nto a new MediaSourcePrivate interface. |
| 617 https://bugs.webkit.org/show_bug.cgi?id=109857 |
| 618 |
| 619 Reviewed by Adam Barth. |
| 620 |
| 621 WebMediaSource and WebMediaSource client were created to replace the Med
iaSource methods in WebMediaPlayer and |
| 622 WebMediaPlayerClient. This allows the MediaSource implementation to be u
pdated without further polluting the |
| 623 media player interfaces. |
| 624 |
| 625 * WebKit.gyp: |
| 626 * public/WebMediaPlayer.h: |
| 627 (WebMediaPlayer): |
| 628 (WebKit::WebMediaPlayer::load): |
| 629 * public/WebMediaPlayerClient.h: |
| 630 (WebKit): |
| 631 * public/WebMediaSource.h: Added. |
| 632 (WebKit): |
| 633 (WebMediaSource): |
| 634 (WebKit::WebMediaSource::~WebMediaSource): |
| 635 * public/WebMediaSourceClient.h: Added. |
| 636 (WebKit): |
| 637 (WebMediaSourceClient): |
| 638 (WebKit::WebMediaSourceClient::~WebMediaSourceClient): |
| 639 * src/AssertMatchingEnums.cpp: |
| 640 * src/WebMediaPlayerClientImpl.cpp: |
| 641 (WebKit): |
| 642 (WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementatio
n to keep things working until Chromium |
| 643 changes land. |
| 644 (WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl): |
| 645 (WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl): |
| 646 (WebKit::WebMediaSourceClientImpl::addId): |
| 647 (WebKit::WebMediaSourceClientImpl::removeId): |
| 648 (WebKit::WebMediaSourceClientImpl::buffered): |
| 649 (WebKit::WebMediaSourceClientImpl::append): |
| 650 (WebKit::WebMediaSourceClientImpl::abort): |
| 651 (WebKit::WebMediaSourceClientImpl::duration): |
| 652 (WebKit::WebMediaSourceClientImpl::setDuration): |
| 653 (WebKit::WebMediaSourceClientImpl::endOfStream): |
| 654 (WebKit::WebMediaSourceClientImpl::setTimestampOffset): |
| 655 (WebKit::WebMediaPlayerClientImpl::sourceOpened): |
| 656 (WebKit::WebMediaPlayerClientImpl::sourceURL): |
| 657 (WebKit::WebMediaPlayerClientImpl::load): |
| 658 (WebKit::WebMediaPlayerClientImpl::loadRequested): |
| 659 (WebKit::WebMediaPlayerClientImpl::loadInternal): |
| 660 * src/WebMediaPlayerClientImpl.h: |
| 661 (WebMediaPlayerClientImpl): |
| 662 * src/WebMediaSourceImpl.cpp: Added. |
| 663 (WebKit): |
| 664 (MediaSourcePrivateImpl): |
| 665 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl): |
| 666 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl): |
| 667 (WebKit::MediaSourcePrivateImpl::addId): |
| 668 (WebKit::MediaSourcePrivateImpl::removeId): |
| 669 (WebKit::MediaSourcePrivateImpl::buffered): |
| 670 (WebKit::MediaSourcePrivateImpl::append): |
| 671 (WebKit::MediaSourcePrivateImpl::abort): |
| 672 (WebKit::MediaSourcePrivateImpl::duration): |
| 673 (WebKit::MediaSourcePrivateImpl::setDuration): |
| 674 (WebKit::MediaSourcePrivateImpl::endOfStream): |
| 675 (WebKit::MediaSourcePrivateImpl::setTimestampOffset): |
| 676 (WebKit::WebMediaSourceImpl::WebMediaSourceImpl): |
| 677 (WebKit::WebMediaSourceImpl::~WebMediaSourceImpl): |
| 678 (WebKit::WebMediaSourceImpl::open): |
| 679 * src/WebMediaSourceImpl.h: Added. |
| 680 (WebKit): |
| 681 (WebMediaSourceImpl): |
| 682 |
| 683 2013-02-22 Alec Flett <alecflett@chromium.org> |
| 684 |
| 685 IndexedDB: Remove old SerializedScriptValue-based get() callbacks |
| 686 https://bugs.webkit.org/show_bug.cgi?id=110626 |
| 687 |
| 688 Reviewed by James Robinson. |
| 689 |
| 690 Removal now that refactoring is complete. |
| 691 |
| 692 * public/WebIDBCallbacks.h: |
| 693 (WebKit): |
| 694 |
| 695 2013-02-22 Ali Juma <ajuma@chromium.org> |
| 696 |
| 697 [chromium] Register newly-created layers for animation |
| 698 https://bugs.webkit.org/show_bug.cgi?id=106594 |
| 699 |
| 700 Reviewed by James Robinson. |
| 701 |
| 702 * WebKit.gyp: |
| 703 * src/ChromeClientImpl.cpp: |
| 704 (WebKit::ChromeClientImpl::ChromeClientImpl): |
| 705 (WebKit::ChromeClientImpl::graphicsLayerFactory): |
| 706 * src/ChromeClientImpl.h: |
| 707 (ChromeClientImpl): |
| 708 * src/GraphicsLayerFactoryChromium.cpp: Added. |
| 709 (WebKit): |
| 710 (WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium): |
| 711 (WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium): |
| 712 (WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer): |
| 713 * src/GraphicsLayerFactoryChromium.h: Added. |
| 714 (WebKit): |
| 715 (GraphicsLayerFactoryChromium): |
| 716 * src/WebViewImpl.cpp: |
| 717 (WebKit::WebViewImpl::WebViewImpl): |
| 718 (WebKit::WebViewImpl::graphicsLayerFactory): |
| 719 (WebKit): |
| 720 (WebKit::WebViewImpl::registerForAnimations): |
| 721 * src/WebViewImpl.h: |
| 722 (WebViewImpl): |
| 723 |
| 724 2013-02-22 Fady Samuel <fsamuel@chromium.org> |
| 725 |
| 726 [Chromium] Expose shadowRoot to the WebKit API |
| 727 https://bugs.webkit.org/show_bug.cgi?id=110522 |
| 728 |
| 729 Reviewed by Dimitri Glazkov. |
| 730 |
| 731 * public/WebElement.h: |
| 732 (WebElement): |
| 733 * src/WebElement.cpp: |
| 734 (WebKit::WebElement::shadowRoot): |
| 735 (WebKit): |
| 736 |
| 737 2013-02-22 Sheriff Bot <webkit.review.bot@gmail.com> |
| 738 |
| 739 Unreviewed, rolling out r143734. |
| 740 http://trac.webkit.org/changeset/143734 |
| 741 https://bugs.webkit.org/show_bug.cgi?id=110615 |
| 742 |
| 743 Causes linux build failures. (Requested by vollick on |
| 744 #webkit). |
| 745 |
| 746 * public/WebKit.h: |
| 747 (WebKit): |
| 748 * src/WebKit.cpp: |
| 749 (WebKit::initialize): |
| 750 (WebKit::initializeWithoutV8): |
| 751 (WebKit::webKitPlatformSupport): |
| 752 |
| 753 2013-02-22 Mikhail Naganov <mnaganov@chromium.org> |
| 754 |
| 755 [Chromium] Add support for emulating legacy Android WebView 'setInitialS
cale' method |
| 756 https://bugs.webkit.org/show_bug.cgi?id=109946 |
| 757 |
| 758 Adding a WebView method for permanently setting initial page scale. |
| 759 This override has higher priority than any calculated page scale |
| 760 and viewport meta tag value. |
| 761 |
| 762 Also, this patch eliminates a dubious "fixed layout enabled, viewport di
sabled" mode |
| 763 previously used by Android WebView. |
| 764 |
| 765 Reviewed by Adam Barth. |
| 766 |
| 767 * public/WebView.h: |
| 768 (WebView): |
| 769 * src/ChromeClientImpl.cpp: |
| 770 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): |
| 771 * src/WebViewImpl.cpp: |
| 772 (WebKit::WebViewImpl::WebViewImpl): |
| 773 (WebKit::WebViewImpl::setInitialPageScaleOverride): |
| 774 (WebKit): |
| 775 (WebKit::WebViewImpl::computePageScaleFactorLimits): |
| 776 * src/WebViewImpl.h: |
| 777 * tests/WebFrameTest.cpp: |
| 778 |
| 779 2013-02-22 Mark Pilgrim <pilgrim@chromium.org> |
| 780 |
| 781 [Chromium] WebKit::initialize should take a Platform* now that WebKitPla
tformSupport is empty |
| 782 https://bugs.webkit.org/show_bug.cgi?id=110605 |
| 783 |
| 784 Reviewed by Adam Barth. |
| 785 |
| 786 Part of a larger refactoring series; see tracking bug 82948. |
| 787 |
| 788 * public/WebKit.h: |
| 789 (WebKit): |
| 790 * src/WebKit.cpp: |
| 791 (WebKit::initialize): |
| 792 (WebKit::initializeWithoutV8): |
| 793 (WebKit::webKitPlatformSupport): |
| 794 |
| 795 2013-02-22 Andrey Kosyakov <caseq@chromium.org> |
| 796 |
| 797 Web Inspector: [Chromium] add a browser test for frames on timeline |
| 798 https://bugs.webkit.org/show_bug.cgi?id=110592 |
| 799 |
| 800 - factor out timeline recording logic from testPageOverlayUpdate for reu
se; |
| 801 - record timeline while running a simple DOM-based animation; |
| 802 - assure we have frames and Style Recalc/Layout/Paint events in between. |
| 803 |
| 804 Reviewed by Yury Semikhatsky. |
| 805 |
| 806 * src/js/Tests.js: |
| 807 (.TestSuite.prototype.assertHasKey): |
| 808 (.TestSuite.prototype.testTimelineFrames.step1): |
| 809 (.TestSuite.prototype.testTimelineFrames.onTimelineRecorded): |
| 810 (.TestSuite.prototype.testTimelineFrames): |
| 811 (.TestSuite.prototype.testPageOverlayUpdate.step4): |
| 812 (.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded): |
| 813 (.TestSuite.prototype.recordTimeline.addRecord): |
| 814 (.TestSuite.prototype.recordTimeline.innerAddRecord): |
| 815 (.TestSuite.prototype.recordTimeline.done): |
| 816 (.TestSuite.prototype.recordTimeline): |
| 817 (.TestSuite.prototype.stopTimeline): |
| 818 |
| 819 2013-02-21 Alec Flett <alecflett@chromium.org> |
| 820 |
| 821 IndexedDB: Implement SharedBuffer version of put() / onSuccess() |
| 822 https://bugs.webkit.org/show_bug.cgi?id=110398 |
| 823 |
| 824 Reviewed by Tony Chang. |
| 825 |
| 826 Proxy new SharedBuffer calls to WebIDBCallbacks through |
| 827 to the new SharedBuffer-based IDBCallbacks. |
| 828 |
| 829 * public/WebIDBCursor.h: |
| 830 * src/IDBCallbacksProxy.cpp: |
| 831 (WebKit::IDBCallbacksProxy::onSuccess): |
| 832 (WebKit::IDBCallbacksProxy::onSuccessWithPrefetch): |
| 833 * src/IDBCallbacksProxy.h: |
| 834 (IDBCallbacksProxy): |
| 835 * src/WebIDBCallbacksImpl.cpp: |
| 836 (WebKit::WebIDBCallbacksImpl::onSuccess): |
| 837 * src/WebIDBCallbacksImpl.h: |
| 838 (WebIDBCallbacksImpl): |
| 839 * tests/IDBAbortOnCorruptTest.cpp: |
| 840 (WebCore::MockIDBCallbacks::onSuccess): |
| 841 (WebCore::MockIDBCallbacks::onSuccessWithPrefetch): |
| 842 * tests/IDBDatabaseBackendTest.cpp: |
| 843 * tests/IDBRequestTest.cpp: |
| 844 (WebKit::TEST_F): |
| 845 |
| 846 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com> |
| 847 |
| 848 Allow to retrieve the request data from abstract TextCheckingRequest to
be accessible for WK2 |
| 849 https://bugs.webkit.org/show_bug.cgi?id=110208 |
| 850 |
| 851 Reviewed by Hajime Morrita. |
| 852 |
| 853 * src/EditorClientImpl.cpp: |
| 854 (WebKit::EditorClientImpl::requestCheckingOfString): |
| 855 Extract the request data as it is the member of 'TextCheckingRequest'. |
| 856 |
| 857 2013-02-21 Mark Pilgrim <pilgrim@chromium.org> |
| 858 |
| 859 [Chromium] Remove chromium/public/platform directory |
| 860 https://bugs.webkit.org/show_bug.cgi?id=110471 |
| 861 |
| 862 Reviewed by Adam Barth. |
| 863 |
| 864 Part of a larger refactoring series; see tracking bug 82948. |
| 865 |
| 866 * WebKit.gyp: |
| 867 * public/platform: Removed. |
| 868 * public/platform/WebKitPlatformSupport.h: Removed. |
| 869 * public/platform/android: Removed. |
| 870 * public/platform/default: Removed. |
| 871 * public/platform/linux: Removed. |
| 872 * public/platform/mac: Removed. |
| 873 * public/platform/win: Removed. |
| 874 * src/WebKit.cpp: |
| 875 |
| 876 2013-02-21 Dirk Pranke <dpranke@chromium.org> |
| 877 |
| 878 [chromium] support the lucid version of freetype on precise in DRT |
| 879 https://bugs.webkit.org/show_bug.cgi?id=107338 |
| 880 |
| 881 Reviewed by Tony Chang. |
| 882 |
| 883 Add in a linux-only dependency on Freetype2 so that we can |
| 884 match the version shipped in Ubuntu Lucid. |
| 885 |
| 886 * DEPS: |
| 887 |
| 888 2013-02-21 Sheriff Bot <webkit.review.bot@gmail.com> |
| 889 |
| 890 Unreviewed. Rolled Chromium DEPS to r183905. Requested by |
| 891 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot. |
| 892 |
| 893 * DEPS: |
| 894 |
| 895 2013-02-21 Alec Flett <alecflett@chromium.org> |
| 896 |
| 897 IndexedDB: Remove copying WebIDBDatabase::put() stub |
| 898 https://bugs.webkit.org/show_bug.cgi?id=109967 |
| 899 |
| 900 Reviewed by Darin Fisher. |
| 901 |
| 902 Now that the chromium call to this method has |
| 903 been removed, we can remove the stub. |
| 904 |
| 905 * public/WebIDBDatabase.h: |
| 906 |
| 907 2013-02-21 Dirk Pranke <dpranke@chromium.org> |
| 908 |
| 909 Unreviewed, roll chromium deps 183552 -> 183788 |
| 910 |
| 911 * DEPS: |
| 912 |
| 913 2013-02-21 John Mellor <johnme@chromium.org> |
| 914 |
| 915 [chromium] Simplify computation of screenRect/windowRect. |
| 916 https://bugs.webkit.org/show_bug.cgi?id=110456 |
| 917 |
| 918 Reviewed by Adam Barth. |
| 919 |
| 920 This patch removes applyDeviceScaleFactorInCompositor checks |
| 921 added by http://trac.webkit.org/changeset/139356 because |
| 922 Chrome for Android now sizes its screen and window in DIP |
| 923 units (like other platforms), so they are no longer necessary. |
| 924 |
| 925 * src/ChromeClientImpl.cpp: |
| 926 (WebKit::ChromeClientImpl::windowRect): |
| 927 |
| 928 2013-02-21 Vsevolod Vlasov <vsevik@chromium.org> |
| 929 |
| 930 Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path f
or displayName instead. |
| 931 https://bugs.webkit.org/show_bug.cgi?id=110335 |
| 932 |
| 933 Reviewed by Alexander Pavlov. |
| 934 |
| 935 * src/js/Tests.js: |
| 936 (.TestSuite.prototype._scriptsAreParsed): |
| 937 |
| 938 2013-02-21 Ken Kania <kkania@chromium.org> |
| 939 |
| 940 Web Inspector: Add command for selecting files for file input element |
| 941 https://bugs.webkit.org/show_bug.cgi?id=109308 |
| 942 |
| 943 Reviewed by Pavel Feldman. |
| 944 |
| 945 * src/InspectorClientImpl.cpp: |
| 946 (WebKit::InspectorClientImpl::canSetFileInputFiles): |
| 947 (WebKit): |
| 948 * src/InspectorClientImpl.h: |
| 949 (InspectorClientImpl): |
| 950 |
| 951 2013-02-20 Paweł Hajdan, Jr. <phajdan.jr@chromium.org> |
| 952 |
| 953 Add gyp option to switch ENABLE(SQL_DATABASE) |
| 954 https://bugs.webkit.org/show_bug.cgi?id=109303 |
| 955 http://code.google.com/p/chromium/issues/detail?id=22208 |
| 956 |
| 957 Reviewed by Tony Chang. |
| 958 |
| 959 This will be useful to implement build with system sqlite. |
| 960 |
| 961 * features.gypi: |
| 962 * src/ChromeClientImpl.cpp: |
| 963 (WebKit): |
| 964 * src/ChromeClientImpl.h: |
| 965 (ChromeClientImpl): |
| 966 |
| 967 2013-02-20 Dirk Schulze <krit@webkit.org> |
| 968 |
| 969 Enable CANVAS_PATH flag |
| 970 https://bugs.webkit.org/show_bug.cgi?id=108508 |
| 971 |
| 972 Reviewed by Simon Fraser. |
| 973 |
| 974 Enable CANVAS_PATH flag on trunk. |
| 975 |
| 976 * features.gypi: |
| 977 |
| 978 2013-02-15 Dirk Schulze <krit@webkit.org> |
| 979 |
| 980 [Chromium] Add runtime flag for CanvasPath |
| 981 https://bugs.webkit.org/show_bug.cgi?id=109997 |
| 982 |
| 983 Reviewed by Adam Barth. |
| 984 |
| 985 Add runtime flag for Chromium. |
| 986 |
| 987 * public/WebRuntimeFeatures.h: |
| 988 (WebRuntimeFeatures): |
| 989 * src/WebRuntimeFeatures.cpp: |
| 990 (WebKit::WebRuntimeFeatures::enableCanvasPath): |
| 991 (WebKit): |
| 992 (WebKit::WebRuntimeFeatures::isCanvasPathEnabled): |
| 993 |
| 994 2013-02-20 Mark Pilgrim <pilgrim@chromium.org> |
| 995 |
| 996 [Chromium] Move WebKitPlatformSupport declaration to Platform.h |
| 997 https://bugs.webkit.org/show_bug.cgi?id=110262 |
| 998 |
| 999 Reviewed by Adam Barth. |
| 1000 |
| 1001 In preparation for removing WebKitPlatformSupport.h entirely (once |
| 1002 downstream references to that file have been updated). Part of a |
| 1003 larger refactoring series; see tracking bug 82948. |
| 1004 |
| 1005 * public/platform/WebKitPlatformSupport.h: |
| 1006 |
| 1007 2013-02-20 Mark Pilgrim <pilgrim@chromium.org> |
| 1008 |
| 1009 [Chromium] Remove idbFactory from WebKitPlatformSupport |
| 1010 https://bugs.webkit.org/show_bug.cgi?id=106457 |
| 1011 |
| 1012 Reviewed by Adam Barth. |
| 1013 |
| 1014 Now that https://codereview.chromium.org/12230054 has landed, the |
| 1015 idbFactory method is no longer needed. (Embedders must now call |
| 1016 the new setIDBFactory method upon initialization.) Part of a |
| 1017 larger refactoring series; see tracking bug 82948. |
| 1018 |
| 1019 * public/platform/WebKitPlatformSupport.h: |
| 1020 (WebKit): |
| 1021 * src/IDBFactoryBackendProxy.cpp: |
| 1022 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): |
| 1023 |
| 1024 2013-02-20 Mark Lam <mark.lam@apple.com> |
| 1025 |
| 1026 Rename DatabaseBackend to DatabaseBackendBase. |
| 1027 https://bugs.webkit.org/show_bug.cgi?id=110303. |
| 1028 |
| 1029 Rubber stamped by Alexey Proskuryakov. |
| 1030 |
| 1031 * public/WebDatabase.h: |
| 1032 (WebDatabase): |
| 1033 * src/DatabaseObserver.cpp: |
| 1034 (WebCore::DatabaseObserver::databaseOpened): |
| 1035 (WebCore::DatabaseObserver::databaseModified): |
| 1036 (WebCore::DatabaseObserver::databaseClosed): |
| 1037 (WebCore::DatabaseObserver::reportOpenDatabaseResult): |
| 1038 (WebCore::DatabaseObserver::reportChangeVersionResult): |
| 1039 (WebCore::DatabaseObserver::reportStartTransactionResult): |
| 1040 (WebCore::DatabaseObserver::reportCommitTransactionResult): |
| 1041 (WebCore::DatabaseObserver::reportExecuteStatementResult): |
| 1042 (WebCore::DatabaseObserver::reportVacuumDatabaseResult): |
| 1043 * src/WebDatabase.cpp: |
| 1044 (WebKit::WebDatabase::WebDatabase): |
| 1045 |
| 1046 2013-02-20 Rouslan Solomakhin <rouslan@chromium.org> |
| 1047 |
| 1048 Fix use after free in ContextMenuClientImpl.cpp |
| 1049 https://bugs.webkit.org/show_bug.cgi?id=109220 |
| 1050 |
| 1051 Reviewed by Tony Chang. |
| 1052 |
| 1053 ContextMenuClientImpl can use a DocumentMarker after it is freed. The Do
cumentMarker is originally allocated |
| 1054 by the spell checker. When the user context-clicks on a misspelling, Con
textMenuClientImpl saves a reference |
| 1055 to the clicked DocumentMarker, changes the selection, and then uses the
DocumentMarker. Changing the selection |
| 1056 causes re-check of spelling. If the spell check client serves the spellc
heck request from cache, then re-checking |
| 1057 spelling will delete the DocumentMarker and add a new one. This invalida
tes the DocumentMarker reference held by |
| 1058 ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the Do
cumentMarker, Address Sanitizer detects |
| 1059 use after free. The fix is to save a copy of the DocumentMarker before c
hanging selection. |
| 1060 |
| 1061 * src/ContextMenuClientImpl.cpp: |
| 1062 (WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before c
hanging selection. |
| 1063 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use Docu
mentMarker instead of Vector<DocumentMarker*>. |
| 1064 |
| 1065 2013-02-20 Sheriff Bot <webkit.review.bot@gmail.com> |
| 1066 |
| 1067 Unreviewed. Rolled Chromium DEPS to r183552. Requested by |
| 1068 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot. |
| 1069 |
| 1070 * DEPS: |
| 1071 |
| 1072 2013-02-19 Adrienne Walker <enne@chromium.org> |
| 1073 |
| 1074 Unreviewed, rolling out r143382 and r143401. |
| 1075 http://trac.webkit.org/changeset/143382 |
| 1076 http://trac.webkit.org/changeset/143401 |
| 1077 https://bugs.webkit.org/show_bug.cgi?id=106457 |
| 1078 |
| 1079 Breaks Chromium win/mac canary compilation |
| 1080 |
| 1081 * public/platform/WebKitPlatformSupport.h: |
| 1082 (WebKit): |
| 1083 (WebKitPlatformSupport): |
| 1084 (WebKit::WebKitPlatformSupport::idbFactory): |
| 1085 (WebKit::WebKitPlatformSupport::~WebKitPlatformSupport): |
| 1086 * src/IDBFactoryBackendProxy.cpp: |
| 1087 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): |
| 1088 |
| 1089 2013-02-19 Mark Pilgrim <pilgrim@chromium.org> |
| 1090 |
| 1091 [Chromium] Move WebKitPlatformSupport declaration to Platform.h |
| 1092 https://bugs.webkit.org/show_bug.cgi?id=110262 |
| 1093 |
| 1094 Reviewed by Adam Barth. |
| 1095 |
| 1096 In preparation for removing WebKitPlatformSupport.h entirely (once |
| 1097 downstream references to that file have been updated). Part of a |
| 1098 larger refactoring series; see tracking bug 82948. |
| 1099 |
| 1100 * public/platform/WebKitPlatformSupport.h: |
| 1101 |
| 1102 2013-02-19 Mark Pilgrim <pilgrim@chromium.org> |
| 1103 |
| 1104 [Chromium] Remove idbFactory from WebKitPlatformSupport |
| 1105 https://bugs.webkit.org/show_bug.cgi?id=106457 |
| 1106 |
| 1107 Reviewed by Kentaro Hara. |
| 1108 |
| 1109 Now that https://codereview.chromium.org/12230054 has landed, the |
| 1110 idbFactory method is no longer needed. (Embedders must now call |
| 1111 the new setIDBFactory method upon initialization.) Part of a |
| 1112 larger refactoring series; see tracking bug 82948. |
| 1113 |
| 1114 * public/platform/WebKitPlatformSupport.h: |
| 1115 (WebKit): |
| 1116 * src/IDBFactoryBackendProxy.cpp: |
| 1117 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy): |
| 1118 |
1 2013-02-19 Alexandre Elias <aelias@chromium.org> | 1119 2013-02-19 Alexandre Elias <aelias@chromium.org> |
2 | 1120 |
3 [chromium] Fix races in double-tap zoom minimum scale policy | 1121 [chromium] Fix races in double-tap zoom minimum scale policy |
4 https://bugs.webkit.org/show_bug.cgi?id=110183 | 1122 https://bugs.webkit.org/show_bug.cgi?id=110183 |
5 | 1123 |
6 Reviewed by Adam Barth. | 1124 Reviewed by Adam Barth. |
7 | 1125 |
8 Double-tap zoom on Android is supposed to return to minimum scale | 1126 Double-tap zoom on Android is supposed to return to minimum scale |
9 if no pinch zoom occurred since the last double-tap. Because both | 1127 if no pinch zoom occurred since the last double-tap. Because both |
10 pinch zoom and the result of double-tap zoom gets passed in from CC | 1128 pinch zoom and the result of double-tap zoom gets passed in from CC |
(...skipping 13986 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
13997 | 15115 |
13998 [Chromium-Win] Implement LocaleWin::dateFormat | 15116 [Chromium-Win] Implement LocaleWin::dateFormat |
13999 https://bugs.webkit.org/show_bug.cgi?id=98117 | 15117 https://bugs.webkit.org/show_bug.cgi?id=98117 |
14000 | 15118 |
14001 Reviewed by Kentaro Hara. | 15119 Reviewed by Kentaro Hara. |
14002 | 15120 |
14003 * tests/LocaleWinTest.cpp: | 15121 * tests/LocaleWinTest.cpp: |
14004 (TEST_F): Add tests for LocaleWin::dateFormat. | 15122 (TEST_F): Add tests for LocaleWin::dateFormat. |
14005 | 15123 |
14006 == Rolled over to ChangeLog-2012-10-02 == | 15124 == Rolled over to ChangeLog-2012-10-02 == |
OLD | NEW |