Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: Source/modules/push_messaging/PushError.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/presentation/PresentationError.cpp ('k') | Source/modules/push_messaging/PushError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushError.h
diff --git a/Source/modules/push_messaging/PushError.h b/Source/modules/push_messaging/PushError.h
index ee59bb9d732d6226725df3049ad87c1e8e52c9ad..ed38bb1126cfb34f90d1af5e729f8168d06a8e8e 100644
--- a/Source/modules/push_messaging/PushError.h
+++ b/Source/modules/push_messaging/PushError.h
@@ -8,8 +8,6 @@
#include "core/dom/DOMException.h"
#include "platform/heap/Handle.h"
#include "public/platform/modules/push_messaging/WebPushError.h"
-#include "wtf/OwnPtr.h"
-#include "wtf/PassOwnPtr.h"
namespace blink {
@@ -19,8 +17,8 @@ class PushError {
WTF_MAKE_NONCOPYABLE(PushError);
public:
// For CallbackPromiseAdapter.
- using WebType = OwnPtr<WebPushError>;
- static DOMException* take(ScriptPromiseResolver*, PassOwnPtr<WebPushError> webError);
+ using WebType = const WebPushError&;
+ static DOMException* take(ScriptPromiseResolver*, const WebPushError& webError);
private:
PushError() = delete;
« no previous file with comments | « Source/modules/presentation/PresentationError.cpp ('k') | Source/modules/push_messaging/PushError.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698