Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: Source/modules/push_messaging/PushError.cpp

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushError.cpp
diff --git a/Source/modules/push_messaging/PushError.cpp b/Source/modules/push_messaging/PushError.cpp
index 6c0746cec53947187e5b36337320d0db3620b6b6..f095d6732a9855d4763dce6cfeeea0e0947de102 100644
--- a/Source/modules/push_messaging/PushError.cpp
+++ b/Source/modules/push_messaging/PushError.cpp
@@ -10,19 +10,19 @@
namespace blink {
-DOMException* PushError::take(ScriptPromiseResolver*, PassOwnPtr<WebPushError> webError)
+DOMException* PushError::take(ScriptPromiseResolver*, const WebPushError& webError)
{
- switch (webError->errorType) {
+ switch (webError.errorType) {
case WebPushError::ErrorTypeAbort:
- return DOMException::create(AbortError, webError->message);
+ return DOMException::create(AbortError, webError.message);
case WebPushError::ErrorTypeNetwork:
- return DOMException::create(NetworkError, webError->message);
+ return DOMException::create(NetworkError, webError.message);
case WebPushError::ErrorTypeNotFound:
- return DOMException::create(NotFoundError, webError->message);
+ return DOMException::create(NotFoundError, webError.message);
case WebPushError::ErrorTypeNotSupported:
- return DOMException::create(NotSupportedError, webError->message);
+ return DOMException::create(NotSupportedError, webError.message);
case WebPushError::ErrorTypeUnknown:
- return DOMException::create(UnknownError, webError->message);
+ return DOMException::create(UnknownError, webError.message);
}
ASSERT_NOT_REACHED();
return DOMException::create(UnknownError);
« no previous file with comments | « Source/modules/push_messaging/PushError.h ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698