public/platform/WebServiceWorkerRegistration.h - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerRegistration.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « public/platform/WebServiceWorkerClientsInfo.h ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/WebServiceWorkerRegistration.h

diff --git a/public/platform/WebServiceWorkerRegistration.h b/public/platform/WebServiceWorkerRegistration.h

index 7f3f2b5d6f7df86dacd6f659dd4acbad008a1a92..389ba8368e14d9b94990e3a0da37faf33d67362e 100644

--- a/public/platform/WebServiceWorkerRegistration.h

+++ b/public/platform/WebServiceWorkerRegistration.h

@@ -18,7 +18,7 @@ class WebServiceWorkerRegistration {

public:

virtual ~WebServiceWorkerRegistration() { }

- using WebServiceWorkerUnregistrationCallbacks = WebCallbacks<bool*, WebPassOwnPtr<WebServiceWorkerError>>;

+ using WebServiceWorkerUnregistrationCallbacks = WebCallbacks<bool, const WebServiceWorkerError&>;

virtual void setProxy(WebServiceWorkerRegistrationProxy*) { }

virtual WebServiceWorkerRegistrationProxy* proxy() { return nullptr; }