public/platform/WebServiceWorkerClientsInfo.h - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerClientsInfo.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « public/platform/WebServiceWorkerClientsClaimCallbacks.h ('k') | public/platform/WebServiceWorkerRegistration.h » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/WebServiceWorkerClientsInfo.h

diff --git a/public/platform/WebServiceWorkerClientsInfo.h b/public/platform/WebServiceWorkerClientsInfo.h

index e934d405ecb343d47a9306ea8fce980bd372ba2f..53dfa93a766eb10676ee90eace6c59f9ca3c272b 100644

--- a/public/platform/WebServiceWorkerClientsInfo.h

+++ b/public/platform/WebServiceWorkerClientsInfo.h

@@ -40,8 +40,8 @@ struct WebServiceWorkerClientsInfo {

};

// Two WebCallbacks, one for one client, one for a WebVector of clients.

-using WebServiceWorkerClientCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerClientInfo>, WebPassOwnPtr<WebServiceWorkerError>>;

-using WebServiceWorkerClientsCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerClientsInfo>, WebPassOwnPtr<WebServiceWorkerError>>;

+using WebServiceWorkerClientCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerClientInfo>, const WebServiceWorkerError&>;

+using WebServiceWorkerClientsCallbacks = WebCallbacks<const WebServiceWorkerClientsInfo&, const WebServiceWorkerError&>;

} // namespace blink