Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1240713002: Fix path to omnibox_focus_state.h in omnibox.gypi (Closed)

Created:
5 years, 5 months ago by brucedawson
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting, blundell
CC:
blundell, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix path to omnibox_focus_state.h In change https://codereview.chromium.org/1224203003 the path to omnibox_focus_state.h was set to a non-existent location. This isn't a serious problem because it's just a header file. This mistake isn't detected when generating ninja files from .gyp files unless msvs-ninja is selected as one of the GYP_GENERATORS. With msvs-ninja the error is revealed with this message: Warning: Missing input files: D:\src\chromium\src\components\omnibox\omnibox_focus_state.h R=pkasting@chromium.org BUG=483424 Committed: https://crrev.com/b902fbc9a8db79ab04476320dadceeb0bf83b571 Cr-Commit-Position: refs/heads/master@{#338733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/omnibox.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
brucedawson
5 years, 5 months ago (2015-07-14 19:48:05 UTC) #1
Peter Kasting
lgtm
5 years, 5 months ago (2015-07-14 19:51:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240713002/1
5 years, 5 months ago (2015-07-14 19:52:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 20:53:01 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b902fbc9a8db79ab04476320dadceeb0bf83b571 Cr-Commit-Position: refs/heads/master@{#338733}
5 years, 5 months ago (2015-07-14 20:53:55 UTC) #6
blundell
5 years, 5 months ago (2015-07-15 09:04:29 UTC) #8
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698