Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224203003: Componentize //chrome/common/omnibox_focus_state.h (Closed)

Created:
5 years, 5 months ago by blundell
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@omnibox_component_browser_subdir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize //chrome/common/omnibox_focus_state.h Requires the creation of //components/omnibox/common. BUG=371536 TBR=sky Committed: https://crrev.com/10cffea10bdc9b7a1e89e972e4a00d2f1814b230 Cr-Commit-Position: refs/heads/master@{#338018}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -60 lines) Patch
M chrome/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_current_page_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/omnibox_focus_state.h View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/omnibox.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
A + components/omnibox/common/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
A + components/omnibox/common/omnibox_focus_state.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
blundell
5 years, 5 months ago (2015-07-09 08:35:15 UTC) #2
Peter Kasting
lgtm
5 years, 5 months ago (2015-07-09 09:30:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224203003/20001
5 years, 5 months ago (2015-07-09 11:26:43 UTC) #6
blundell
TBR=sky for //chrome outside of //chrome/*omnibox*
5 years, 5 months ago (2015-07-09 11:30:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224203003/20001
5 years, 5 months ago (2015-07-09 11:30:36 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
5 years, 5 months ago (2015-07-09 11:45:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224203003/20001
5 years, 5 months ago (2015-07-09 12:34:11 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 12:38:43 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 12:39:26 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/10cffea10bdc9b7a1e89e972e4a00d2f1814b230
Cr-Commit-Position: refs/heads/master@{#338018}

Powered by Google App Engine
This is Rietveld 408576698