Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1240633005: Some cleanups of VisualBench (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : big comment #

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -53 lines) Patch
M tools/VisualBench/VisualBench.h View 1 2 2 chunks +38 lines, -8 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 4 chunks +85 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-17 13:55:03 UTC) #2
bsalomon
https://codereview.chromium.org/1240633005/diff/1/tools/VisualBench/VisualBench.h File tools/VisualBench/VisualBench.h (right): https://codereview.chromium.org/1240633005/diff/1/tools/VisualBench/VisualBench.h#newcode42 tools/VisualBench/VisualBench.h:42: enum State { Needs some comments here... This is ...
5 years, 5 months ago (2015-07-17 15:18:22 UTC) #3
joshualitt
On 2015/07/17 15:18:22, bsalomon wrote: > https://codereview.chromium.org/1240633005/diff/1/tools/VisualBench/VisualBench.h > File tools/VisualBench/VisualBench.h (right): > > https://codereview.chromium.org/1240633005/diff/1/tools/VisualBench/VisualBench.h#newcode42 > ...
5 years, 5 months ago (2015-07-17 15:50:50 UTC) #4
bsalomon
lgtm
5 years, 5 months ago (2015-07-17 15:59:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240633005/40001
5 years, 5 months ago (2015-07-17 16:01:56 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 16:09:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a2a6fe86998035f9930f31a84bce508ada044910

Powered by Google App Engine
This is Rietveld 408576698