Pass ID of the calling extension to the native messaging host.

Pass ID of the calling extension to the native messaging host.

Previously native hosts didn't have a way to know which extension started 
them. With this change security origin of the calling extension will be 
passed to the native host process as a parameter, so that it knows which 
extension is calling it.

BUG=142915
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186297

[Matt Perry, 2013-03-05 18:19:24]

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
File chrome/browser/extensions/api/messaging/native_process_launcher.h (right):

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
chrome/browser/extensions/api/messaging/native_process_launcher.h:56: static
bool LaunchNativeProcess(
I think it would be better to have this method accept a path and origin_url.
Otherwise, the CommandLine parameter is opaque, and it's unclear what arguments
you should pass.

[Sergey Ulanov, 2013-03-05 19:03:05]

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
File chrome/browser/extensions/api/messaging/native_process_launcher.h (right):

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
chrome/browser/extensions/api/messaging/native_process_launcher.h:56: static
bool LaunchNativeProcess(
On 2013/03/05 18:19:24, Matt Perry wrote:
> I think it would be better to have this method accept a path and origin_url.
> Otherwise, the CommandLine parameter is opaque, and it's unclear what
arguments
> you should pass.

This method is protected and supposed to be called by NativeProcessLauncherImpl
only. I think it's better to pass command line here is because we always want to
use the same command line on all platforms so the code that creates command line
should be shared between platforms.

[Matt Perry, 2013-03-05 19:14:25]

lgtm

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
File chrome/browser/extensions/api/messaging/native_process_launcher.h (right):

https://codereview.chromium.org/12406002/diff/1001/chrome/browser/extensions/...
chrome/browser/extensions/api/messaging/native_process_launcher.h:56: static
bool LaunchNativeProcess(
On 2013/03/05 19:03:05, sergeyu wrote:
> On 2013/03/05 18:19:24, Matt Perry wrote:
> > I think it would be better to have this method accept a path and origin_url.
> > Otherwise, the CommandLine parameter is opaque, and it's unclear what
> arguments
> > you should pass.
> 
> This method is protected and supposed to be called by
NativeProcessLauncherImpl
> only. I think it's better to pass command line here is because we always want
to
> use the same command line on all platforms so the code that creates command
line
> should be shared between platforms.

Oh OK, that makes sense.

nit: fix the variable name here

[jschuh, 2013-03-05 21:36:11]

When I try to view the most recent diffs I get:
  error: old chunk mismatch

[Sergey Ulanov, 2013-03-05 21:58:54]

On 2013/03/05 21:36:11, Justin Schuh wrote:
> When I try to view the most recent diffs I get:
>   error: old chunk mismatch

Reuploaded it. Try again please.

[jschuh, 2013-03-05 22:01:24]

On 2013/03/05 21:58:54, sergeyu wrote:
> On 2013/03/05 21:36:11, Justin Schuh wrote:
> > When I try to view the most recent diffs I get:
> >   error: old chunk mismatch
> 
> Reuploaded it. Try again please.

Thanks. lgtm

[Sergey Ulanov, 2013-03-06 00:36:29]

Committed patchset #4 manually as r186297 (presubmit successful).