Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: chrome/test/data/extensions/api_test/native_messaging/test.js

Issue 12406002: Pass ID of the calling extension to the native messaging host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/native_messaging/test.js
diff --git a/chrome/test/data/extensions/api_test/native_messaging/test.js b/chrome/test/data/extensions/api_test/native_messaging/test.js
index 2715a4288f79f177848520720d15d0bc11327f15..ab01956e1d6eb5dea81cdbd287ceb03ed9038fcf 100644
--- a/chrome/test/data/extensions/api_test/native_messaging/test.js
+++ b/chrome/test/data/extensions/api_test/native_messaging/test.js
@@ -11,9 +11,11 @@ chrome.test.getConfig(function(config) {
var message = {"text": "Hi there!", "number": 3};
chrome.runtime.sendNativeMessage(
appName, message,
- chrome.test.callbackPass(function(nativeResponse) {
- var expectedResponse = {"id": 1, "echo": message};
- chrome.test.assertEq(expectedResponse, nativeResponse);
+ chrome.test.callbackPass(function(response) {
+ chrome.test.assertEq(1, response.id);
+ chrome.test.assertEq(message, response.echo);
+ chrome.test.assertEq(
+ response.caller_url, window.location.origin + "/");
}));
},
@@ -28,19 +30,19 @@ chrome.test.getConfig(function(config) {
var messagesToSend = [{"text": "foo"},
{"text": "bar", "funCount": 9001},
{}];
- var expectedResponses = [{"id": 1, "echo": messagesToSend[0]},
- {"id": 2, "echo": messagesToSend[1]},
- {"id": 3, "echo": messagesToSend[2]}];
var currentMessage = 0;
port = chrome.extension.connectNative(appName);
port.postMessage(messagesToSend[currentMessage]);
port.onMessage.addListener(function(message) {
- chrome.test.assertEq(expectedResponses[currentMessage], message);
+ chrome.test.assertEq(currentMessage + 1, message.id);
+ chrome.test.assertEq(messagesToSend[currentMessage], message.echo);
+ chrome.test.assertEq(
+ message.caller_url, window.location.origin + "/");
currentMessage++;
- if (currentMessage == expectedResponses.length)
+ if (currentMessage == messagesToSend.length)
chrome.test.notifyPass();
else
port.postMessage(messagesToSend[currentMessage]);

Powered by Google App Engine
This is Rietveld 408576698