Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1240573011: Check cancellation before reporting crypto result. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
haraken, eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check cancellation before reporting crypto result. Should Blink have cancelled the crypto operation, do not go ahead and try to report the result. The objects involved cannot be assumed to be a valid state. R= BUG=440450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M components/webcrypto/webcrypto_impl.cc View 12 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
please take a look. Makes sense on its own, but needed to make https://codereview.chromium.org/1228373006/ reliable.
5 years, 5 months ago (2015-07-15 12:47:54 UTC) #2
haraken
non-owner LGTM
5 years, 5 months ago (2015-07-15 13:56:06 UTC) #3
eroman
not lgtm. If additional checks for cancellation are needed, please add them as part of ...
5 years, 5 months ago (2015-07-15 20:39:32 UTC) #4
sof
5 years, 5 months ago (2015-07-15 21:01:59 UTC) #5
On 2015/07/15 20:39:32, eroman wrote:
> not lgtm.
> 
> If additional checks for cancellation are needed, please add them as part of
> WebCryptoResult / WebCryptoResultImpl instead, rather than at each callsite to
> WebCryptoResult.

ok, the commit*() methods on WebCryptoResult gate on cancellation status instead
( https://codereview.chromium.org/1228373006/ )

Powered by Google App Engine
This is Rietveld 408576698