Issue 1240573007: Make it possible to detect PopupMenuItem presses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1240573007: Make it possible to detect PopupMenuItem presses (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make it possible to detect PopupMenuItem presses R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3235a05ffb37d6f6eb38b266b1787adeec881677

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -10 lines)			Patch
M	sky/sdk/example/stocks/lib/stock_menu.dart	View	2 chunks	+5 lines, -4 lines	1 comment	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu_item.dart	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1240573007/diff/1/sky/sdk/example/stocks/lib/stock_menu.dart File sky/sdk/example/stocks/lib/stock_menu.dart (right): https://codereview.chromium.org/1240573007/diff/1/sky/sdk/example/stocks/lib/stock_menu.dart#newcode37 sky/sdk/example/stocks/lib/stock_menu.dart:37: new PopupMenuItem(child: new Text('Add stock')), should we have ...

5 years, 5 months ago (2015-07-14 17:57:54 UTC) #2

abarth-chromium

5 years, 5 months ago (2015-07-14 17:58:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3235a05ffb37d6f6eb38b266b1787adeec881677 (presubmit successful).

Expand Messages | Collapse Messages