Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1240573007: Make it possible to detect PopupMenuItem presses (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M sky/sdk/example/stocks/lib/stock_menu.dart View 2 chunks +5 lines, -4 lines 1 comment Download
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 17:55:32 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1240573007/diff/1/sky/sdk/example/stocks/lib/stock_menu.dart File sky/sdk/example/stocks/lib/stock_menu.dart (right): https://codereview.chromium.org/1240573007/diff/1/sky/sdk/example/stocks/lib/stock_menu.dart#newcode37 sky/sdk/example/stocks/lib/stock_menu.dart:37: new PopupMenuItem(child: new Text('Add stock')), should we have ...
5 years, 5 months ago (2015-07-14 17:57:54 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-14 17:58:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3235a05ffb37d6f6eb38b266b1787adeec881677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698