Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2284)

Unified Diff: sky/sdk/example/stocks/lib/stock_menu.dart

Issue 1240573007: Make it possible to detect PopupMenuItem presses (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/popup_menu.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/stocks/lib/stock_menu.dart
diff --git a/sky/sdk/example/stocks/lib/stock_menu.dart b/sky/sdk/example/stocks/lib/stock_menu.dart
index c122695666b8ac2bd2ea8b9286452c9aaf0067aa..6ef3f4e8138afa0403b5413441fd738b0eb5e935 100644
--- a/sky/sdk/example/stocks/lib/stock_menu.dart
+++ b/sky/sdk/example/stocks/lib/stock_menu.dart
@@ -4,9 +4,10 @@
import 'dart:sky' as sky;
+import 'package:sky/widgets/basic.dart';
import 'package:sky/widgets/checkbox.dart';
+import 'package:sky/widgets/popup_menu_item.dart';
import 'package:sky/widgets/popup_menu.dart';
-import 'package:sky/widgets/basic.dart';
export 'package:sky/widgets/popup_menu.dart' show PopupMenuStatus;
@@ -33,9 +34,9 @@ class StockMenu extends Component {
return new Positioned(
child: new PopupMenu(
items: [
- new Text('Add stock'),
- new Text('Remove stock'),
- new Flex([new Flexible(child: new Text('Autorefresh')), checkbox]),
+ new PopupMenuItem(child: new Text('Add stock')),
Hixie 2015/07/14 17:57:54 should we have a PopupMenuItem.text('Add stock') c
+ new PopupMenuItem(child: new Text('Remove stock')),
+ new PopupMenuItem(child: new Flex([new Flexible(child: new Text('Autorefresh')), checkbox])),
],
level: 4,
showing: showing,
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/popup_menu.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698