Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1240553003: d8: Leak context_mutex_ so it will never be destroyed while locked (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

d8: Leak context_mutex_ so it will never be destroyed while locked Calling quit() from d8 will call exit(), which will run static destructors. If context_mutex_ is statically allocated, pthread_mutex_destroy will be called. When running d8 in "isolates" mode, another thread may be running. If it calls CreateEvaluationContext, it will lock the context_mutex_. If the mutex is destroyed while it is locked, it will return an error. This CL changes the Mutex to a LazyMutex, which will leak instead of being destroyed. BUG=v8:4279 R=jarin@chromium.org R=machenbach@chromium.org LOG=n Committed: https://crrev.com/162f116a913058cb02f0e5fe1becf7c11d1db56b Cr-Commit-Position: refs/heads/master@{#29709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/d8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/d8.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
binji
5 years, 5 months ago (2015-07-16 01:00:10 UTC) #1
Jarin
lgtm.
5 years, 5 months ago (2015-07-16 09:42:11 UTC) #2
Michael Achenbach
lgtm
5 years, 5 months ago (2015-07-16 12:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240553003/1
5 years, 5 months ago (2015-07-16 16:39:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 16:40:44 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 16:41:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/162f116a913058cb02f0e5fe1becf7c11d1db56b
Cr-Commit-Position: refs/heads/master@{#29709}

Powered by Google App Engine
This is Rietveld 408576698