src/d8.h - Issue 1240553003: d8: Leak context_mutex_ so it will never be destroyed while locked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.h

Issue 1240553003: d8: Leak context_mutex_ so it will never be destroyed while locked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/d8.h

diff --git a/src/d8.h b/src/d8.h

index bb5592bec4f49c2d98edba0de324c686a97b903e..ae61dcc63e0ed1df20ff6e8e690713c7950ef437 100644

--- a/src/d8.h

+++ b/src/d8.h

@@ -481,10 +481,10 @@ class Shell : public i::AllStatic {

static CounterCollection local_counters_;

static CounterCollection* counters_;

static base::OS::MemoryMappedFile* counters_file_;

- static base::Mutex context_mutex_;

+ static base::LazyMutex context_mutex_;

static const base::TimeTicks kInitialTicks;

- static base::Mutex workers_mutex_;

+ static base::LazyMutex workers_mutex_;

static bool allow_new_workers_;

static i::List<Worker*> workers_;

static i::List<SharedArrayBuffer::Contents> externalized_shared_contents_;

« no previous file with comments | « no previous file | src/d8.cc » ('j') | no next file with comments »