Fix check for a date with a 24th hour

src/dateparser.cc

Index: src/dateparser.cc
diff --git a/src/dateparser.cc b/src/dateparser.cc
index 0e5cc8c3ef90b94158bd6307acac8dddc99e292f..91b9f268b3a1a538286ee47e1aaf461537165f2c 100644
--- a/src/dateparser.cc
+++ b/src/dateparser.cc
@@ -80,7 +80,13 @@ bool DateParser::TimeComposer::Write(FixedArray* output) {
   }
 
   if (!IsHour(hour) || !IsMinute(minute) ||
-      !IsSecond(second) || !IsMillisecond(millisecond)) return false;
+      !IsSecond(second) || !IsMillisecond(millisecond)) {
+    if (hour == 24 && minute == 0 && second == 0 && millisecond == 0) {

[rossberg, 2015/07/22 09:48:57]

Invert to (hour != 24 || minute != 0 || second != 0 || millisecond != 0) and
drop the else branch.

[hichris123, 2015/07/22 22:44:17]

Done.

+      // A 24th hour is allowed if minutes, seconds, and milliseconds are 0
+    } else {
+      return false;
+    }
+  }
 
   output->set(HOUR, Smi::FromInt(hour));
   output->set(MINUTE, Smi::FromInt(minute));