Fix check for a date with a 24th hour

src/dateparser.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/dateparser.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 62 matching lines @@
   int& second = comp_[2];
   int& millisecond = comp_[3];
 
   if (hour_offset_ != kNone) {
     if (!IsHour12(hour)) return false;
     hour %= 12;
     hour += hour_offset_;
   }
 
   if (!IsHour(hour) || !IsMinute(minute) ||
-      !IsSecond(second) || !IsMillisecond(millisecond)) return false;
+      !IsSecond(second) || !IsMillisecond(millisecond)) {
+    if (hour == 24 && minute == 0 && second == 0 && millisecond == 0) {

[rossberg, 2015/07/22 09:48:57]

Invert to (hour != 24 || minute != 0 || second != 0 || millisecond != 0) and
drop the else branch.

[hichris123, 2015/07/22 22:44:17]

Done.

+      // A 24th hour is allowed if minutes, seconds, and milliseconds are 0
+    } else {
+      return false;
+    }
+  }
 
   output->set(HOUR, Smi::FromInt(hour));
   output->set(MINUTE, Smi::FromInt(minute));
   output->set(SECOND, Smi::FromInt(second));
   output->set(MILLISECOND, Smi::FromInt(millisecond));
   return true;
 }
 
 
 bool DateParser::TimeZoneComposer::Write(FixedArray* output) {
@@ skipping 88 matching lines @@
       length--;
     } while (length > 3);
     number /= factor;
   }
   return number;
 }
 
 
 }  // namespace internal
 }  // namespace v8