Fix check for a date with a 24th hour

Fix check for a date with a 24th hour

According to the ECMA spec, a 24th hour is allowed if the minutes, seconds, and milliseconds are all zero (i.e. it's midnight). Previously, we parsed the date correctly, however, we failed to account in all checks for the possibility of a 24th hour. This CL changes the check to allow a 24th hour if it's exactly midnight.

BUG=chromium:174609
LOG=Y

Committed: https://crrev.com/ea056cbf2d338f95fe40381c7adf0133df5ed3c9
Cr-Commit-Position: refs/heads/master@{#29816}

[hichris123, 2015-07-18 02:37:10]

hichris123@gmail.com changed reviewers:
+ adamk@chromium.org

[hichris123, 2015-07-18 03:22:26]

adamk@: PTAL. Not sure if you're a good reviewer for this, if not, please let me
know.

[hichris123, 2015-07-21 23:50:37]

hichris123@gmail.com changed reviewers:
+ rossberg@chromium.org

[hichris123, 2015-07-21 23:51:20]

Actually, +rossberg@ since it seems this is more of your expertise.

[rossberg, 2015-07-22 09:48:57]

Looks good, just a nit.

https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc
File src/dateparser.cc (right):

https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc#newco...
src/dateparser.cc:84: if (hour == 24 && minute == 0 && second == 0 &&
millisecond == 0) {
Invert to (hour != 24 || minute != 0 || second != 0 || millisecond != 0) and
drop the else branch.

[hichris123, 2015-07-22 22:44:17]

https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc
File src/dateparser.cc (right):

https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc#newco...
src/dateparser.cc:84: if (hour == 24 && minute == 0 && second == 0 &&
millisecond == 0) {
On 2015/07/22 09:48:57, rossberg wrote:
> Invert to (hour != 24 || minute != 0 || second != 0 || millisecond != 0) and
> drop the else branch.

Done.

[rossberg, 2015-07-23 09:39:51]

lgtm

[hichris123, 2015-07-23 14:24:21]

The CQ bit was checked by hichris123@gmail.com

[commit-bot: I haz the power, 2015-07-23 14:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240093005/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1240093005/90001

[commit-bot: I haz the power, 2015-07-23 14:37:48]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2015-07-23 14:37:55]

Patchset 6 (id:??) landed as
https://crrev.com/ea056cbf2d338f95fe40381c7adf0133df5ed3c9
Cr-Commit-Position: refs/heads/master@{#29816}