Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8087)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1239963004: Settings Rewrite: Morph old MD-Settings to Basic and Advanced menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 30f215c8c9d47e198476652e6658f8004bb38714..0201c4c1d0d6da604a85a714438cdd7fe5413173 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -61,6 +61,11 @@ void AddA11yStrings(content::WebUIDataSource* html_source) {
"onScreenKeyboardLabel", IDS_SETTINGS_ON_SCREEN_KEYBOARD_LABEL);
}
+void AddAdvancedStrings(content::WebUIDataSource* html_source) {
+ html_source->AddLocalizedString("advancedPageTitle",
michaelpg 2015/07/20 21:23:10 We don't anticipate more strings than this, do we?
tommycli 2015/07/20 22:58:58 Done.
+ IDS_SETTINGS_ADVANCED_PAGE_TITLE);
+}
+
void AddAppearanceStrings(content::WebUIDataSource* html_source) {
html_source->AddLocalizedString(
"appearancePageTitle", IDS_SETTINGS_APPEARANCE_PAGE_TITLE);
@@ -82,6 +87,11 @@ void AddAppearanceStrings(content::WebUIDataSource* html_source) {
"themesGalleryUrl", IDS_THEMES_GALLERY_URL);
}
+void AddBasicStrings(content::WebUIDataSource* html_source) {
+ html_source->AddLocalizedString("basicPageTitle",
+ IDS_SETTINGS_BASIC_PAGE_TITLE);
+}
+
void AddCommonStrings(content::WebUIDataSource* html_source) {
html_source->AddLocalizedString("addLabel", IDS_ADD);
}
@@ -263,7 +273,9 @@ namespace settings {
void AddLocalizedStrings(content::WebUIDataSource* html_source) {
AddA11yStrings(html_source);
+ AddAdvancedStrings(html_source);
AddAppearanceStrings(html_source);
+ AddBasicStrings(html_source);
AddCommonStrings(html_source);
AddDownloadsStrings(html_source);
AddDateTimeStrings(html_source);

Powered by Google App Engine
This is Rietveld 408576698